Closed Bug 1354415 Opened 4 years ago Closed 2 months ago

Intermittent browser/base/content/test/webextensions/browser_extension_update_background.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -

Categories

(WebExtensions :: General, defect, P5)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: intermittent-bug-filer, Assigned: gbrown)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed])

Attachments

(1 file)

Assignee: nobody → gbrown
Blocks: 1341337
This test was timing out in bug 1341337; I split out browser_extension_update_background_noprompt.js and that seemed to help for a few days, but then time outs started again.

Test durations for browser/base/content/test/webextensions/browser_extension_update_background.js on mozilla-central,mozilla-inbound,autoland between 2017-04-19 and 2017-04-26
linux32/debug-chunked:          71.04 s (51.57 s - 90.83 s over 348 runs)
linux32/debug-e10s:             73.20 s (58.39 s - 90.83 s over 147 runs)
linux32/opt-chunked:            19.63 s (12.25 s - 42.70 s over 560 runs)
linux32/opt-e10s:               20.90 s (14.95 s - 42.70 s over 214 runs)
linux64/asan-chunked:           33.56 s (21.60 s - 66.03 s over 583 runs)
linux64/asan-e10s:              37.02 s (26.39 s - 66.03 s over 220 runs)
linux64/debug-chunked:          69.84 s (48.25 s - 91.44 s over 305 runs)
linux64/debug-e10s:             70.64 s (50.36 s - 86.82 s over 147 runs)
linux64/opt-chunked:            18.93 s (12.52 s - 41.06 s over 302 runs)
linux64/opt-e10s:               20.46 s (13.65 s - 38.06 s over 147 runs)
linux64/pgo-chunked:            17.49 s (8.43 s - 43.26 s over 384 runs)
linux64/pgo-e10s:               17.74 s (12.37 s - 43.26 s over 225 runs)

Test durations for browser/base/content/test/webextensions/browser_extension_update_background_noprompt.js on mozilla-central,mozilla-inbound,autoland between 2017-04-19 and 2017-04-26
linux32/debug-chunked:          26.02 s (14.62 s - 46.28 s over 362 runs)
linux32/debug-e10s:             28.88 s (20.39 s - 46.28 s over 156 runs)
linux32/opt-chunked:            10.30 s (4.27 s - 38.93 s over 560 runs)
linux32/opt-e10s:               10.78 s (6.26 s - 38.93 s over 214 runs)
linux64/asan-chunked:           15.17 s (7.65 s - 32.24 s over 583 runs)
linux64/asan-e10s:              17.60 s (12.02 s - 32.24 s over 220 runs)
linux64/debug-chunked:          24.97 s (14.81 s - 55.54 s over 310 runs)
linux64/debug-e10s:             26.95 s (18.04 s - 55.54 s over 151 runs)
linux64/opt-chunked:            10.01 s (3.84 s - 29.36 s over 303 runs)
linux64/opt-e10s:               11.22 s (6.02 s - 29.36 s over 147 runs)
linux64/pgo-chunked:             9.71 s (3.33 s - 30.03 s over 384 runs)
linux64/pgo-e10s:               10.36 s (5.27 s - 28.42 s over 225 runs)

All the failure logs I have checked show the test making progress just before the time out, so I think allowing more time will be effective.

If you'd prefer to optimize or split the test further, that's fine with me, but please re-assign the bug.
Attachment #8861966 - Flags: review?(aswan)
Comment on attachment 8861966 [details] [diff] [review]
requestLongerTimeout

Review of attachment 8861966 [details] [diff] [review]:
-----------------------------------------------------------------

I'll try to look more closely and get a better permanent solution soon, but in the meantime, thanks for this...
Attachment #8861966 - Flags: review?(aswan) → review+
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d16f51ca4750
requestLongerTimeout for browser_extension_update_background.js; r=aswan
(In reply to Andrew Swan [:aswan] from comment #4)
> I'll try to look more closely and get a better permanent solution soon,

That's great. I'll leave-open and re-assign to keep this on your radar.
Assignee: gbrown → aswan
Keywords: leave-open
Whiteboard: [stockwell fixed]
Assignee: aswan → nobody
Priority: -- → P5
Product: Toolkit → WebExtensions
The leave-open keyword is there and there is no activity for 6 months.
:ddurst, maybe it's time to close this bug?
Flags: needinfo?(ddurst)
Flags: needinfo?(thedurst)
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Assignee: nobody → whole.grains
You need to log in before you can comment on or make changes to this bug.