Closed
Bug 1354436
Opened 7 years ago
Closed 7 years ago
Starting with MOZ_PROFILER_HELP=(anything) causes segfault
Categories
(Core :: Gecko Profiler, enhancement)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jseward, Assigned: n.nethercote)
Details
Attachments
(1 file)
|
861 bytes,
patch
|
jseward
:
review+
|
Details | Diff | Splinter Review |
.. because the following assertion fails
static void
PrintUsageThenExit(int aExitCode)
{
MOZ_RELEASE_ASSERT(NS_IsMainThread());
MOZ_RELEASE_ASSERT(gPS); <---------------------
.. because profiler_init calls PrintUsageThenExit before setting gPS.
Given that PrintUsageThenExit shuts down the process, we don't care
about the state of the system if we're calling it, so it seems simplest
to just remove the assertion.
|
Assignee | |
Comment 1•7 years ago
|
||
Whoops. Thank you for reporting.
Attachment #8856325 -
Flags: review?(jseward)
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
|
Reporter | |
Updated•7 years ago
|
Attachment #8856325 -
Flags: review?(jseward) → review+
|
|
Assignee | |
Comment 2•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef60cbd89dd64e2dffb63c70df98deecb33c736b Bug 1354436 - Fix crash when MOZ_PROFILER_HELP is specified. r=jseward.
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ef60cbd89dd6
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•