Closed
Bug 1354465
Opened 7 years ago
Closed 7 years ago
Leaving MDSM::DORMANT state should not trigger throbber UI.
Categories
(Core :: Audio/Video: Playback, defect, P1)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: kaku, Assigned: kaku)
References
Details
Attachments
(2 files)
Spawn from bug 1348085 comment 4.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → kaku
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=393c001c323cd6020f563c8a980d7cd65d9daf77 https://treeherder.mozilla.org/#/jobs?repo=try&revision=06225ee2ff54ace6dd1646974eab64afa3ad80bc
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8855691 [details] Bug 1354465 P1 - dispatch a mozvideoonlyseekbegin event while starting a video-only seek; https://reviewboard.mozilla.org/r/127570/#review130280 ::: dom/media/MediaDecoderStateMachine.cpp:527 (Diff revision 1) > { > - // Do nothing since we won't resume decoding until exiting dormant. > + // We're in DORMANT state so we don't need to resume immediately. > + // However, we still need to notify the reader that we don't want to use > + // null decoder anymore, so that the reader will create a standard video > + // decoder next time the playback is restarted again. > + MOZ_ASSERT(mMaster->mVideoDecodeSuspended); We will miss the "mozexitvideosuspend" event this way. I think we should add a new event, "mozvideoonlyseekbegin" to pair with "mozvideoonlyseekcompleted" which will notify the throbber to begin and stop.
Attachment #8855691 -
Flags: review?(jwwang) → review-
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8855691 [details] Bug 1354465 P1 - dispatch a mozvideoonlyseekbegin event while starting a video-only seek; https://reviewboard.mozilla.org/r/127570/#review130326
Attachment #8855691 -
Flags: review?(jwwang) → review+
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8855733 [details] Bug 1354465 P2 - use mozvideoonlyseekbegin event to start throbber timer; https://reviewboard.mozilla.org/r/127640/#review130328
Attachment #8855733 -
Flags: review?(jwwang) → review+
Assignee | ||
Comment 8•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e57644dcd419bf6bedd7eab2be55d41f39c24c6a https://treeherder.mozilla.org/#/jobs?repo=try&revision=3802ec48b7496304ff3a899ba5da3c24245ac62c
Assignee | ||
Updated•7 years ago
|
Summary: Implement HandleResumeVideoDecoding() for MDSM::DORMANT state → Leaving MDSM::DORMANT state should not trigger throbber UI.
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8855733 [details] Bug 1354465 P2 - use mozvideoonlyseekbegin event to start throbber timer; https://reviewboard.mozilla.org/r/127640/#review131158
Attachment #8855733 -
Flags: review?(jaws) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 13•7 years ago
|
||
Thanks for the review!
Comment 14•7 years ago
|
||
Pushed by tkuo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bc63b56a88dd P1 - dispatch a mozvideoonlyseekbegin event while starting a video-only seek; r=jwwang https://hg.mozilla.org/integration/autoland/rev/e2c9182cddb1 P2 - use mozvideoonlyseekbegin event to start throbber timer; r=jaws,jwwang
Comment 15•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bc63b56a88dd https://hg.mozilla.org/mozilla-central/rev/e2c9182cddb1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•