Closed Bug 1354510 Opened 6 years ago Closed 6 years ago

Firefox build should recognize Solaris

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Version:
52 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox55 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: petr.sumbera, Assigned: petr.sumbera)

Details

Attachments

(1 file, 2 obsolete files)

Bug1354510.patch
3.71 KB, patch
glandium
: review+
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170323105023

Steps to reproduce:

Firefox should provide support for build on Solaris OS like it does for others.
Attached patch Bug1354510.patch (obsolete) — — Splinter Review 

    
  

        Attachment #8855756 -
        Flags: review?(mh+mozilla)

    
  
Component: Untriaged → Build Config

    
    

    
  
Comment on attachment 8855756 [details] [diff] [review]
Bug1354510.patch

Review of attachment 8855756 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/moz.configure/init.configure
@@ +616,5 @@
> +def target_is_solaris(target):
> +    if target.kernel == 'SunOS':
> +        return True
> +
> +set_define('XP_SOLARIS', target_is_solaris)

This doesn't really feel necessary, unless it's going to be used (which it currently isn't)

::: ipc/chromium/src/build/build_config.h
@@ +32,4 @@
>  #define OS_NETBSD 1
>  #elif defined(__OpenBSD__)
>  #define OS_OPENBSD 1
> +#elif defined(__sun__) || defined(__sun)

You can leave out __sun, since constants.py expects __sun__ only.

        Attachment #8855756 -
        Flags: review?(mh+mozilla)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Bug1354510.patch (obsolete)
        — 
          — Splinter Review
      

    


  
I have one XP_SOLARIS use in queue so I have added it to the patch. And removed __sun.

        Attachment #8855756 -
        Attachment is obsolete: true

        Attachment #8856842 -
        Flags: review?(mh+mozilla)

    
    

    
  
(In reply to Petr Sumbera from comment #3)
> Created attachment 8856842 [details] [diff] [review]
> Bug1354510.patch
> 
> I have one XP_SOLARIS use in queue so I have added it to the patch. And
> removed __sun.

Can you remove https://dxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/moz.build#91-93 then?

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Bug1354510.patch
        — 
          — Splinter Review
      

    


  

        Attachment #8856842 -
        Attachment is obsolete: true

        Attachment #8856842 -
        Flags: review?(mh+mozilla)

        Attachment #8856932 -
        Flags: review?(mh+mozilla)

        Attachment #8856932 -
        Flags: review?(mh+mozilla) → review+

    
  
Keywords: checkin-needed
Assignee: nobody → petr.sumbera

    
    

    
  
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d99f00376b25
Firefox build should recognize Solaris. r=glandium
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/d99f00376b25
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago

          status-firefox55:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 55 → mozilla55

          You need to log in
          before you can comment on or make changes to this bug.