Use HTTPS and update domain/parameters for Yahoo! auction search plug-in

RESOLVED FIXED in Firefox 56

Status

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bugzilla, Assigned: m_kato)

Tracking

unspecified
mozilla56
All
Unspecified

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

2 years ago
Currently we use HTTP for Yahoo! Auction search plug-in but we want to switch to HTTPS when they use it.

According to the Yahoo auction property staff, they're planing to switch to HTTPS in May (originally in March) and we can use HTTPS from June.

Not decided but they're also planning to change domain or parameters.
I'll ask them again when time comes and will attach the patch for it.

ref: search plug-in file:
https://hg.mozilla.org/mozilla-central/file/tip/browser/locales/searchplugins/yahoo-jp-auctions.xml
Assignee

Comment 1

2 years ago
Asai-san, Now is July.  Can we change to HTTPS for Yahoo Auction search plugin?
Flags: needinfo?(bugzilla)
Reporter

Comment 2

2 years ago
Waiting confirmation from Yahoo. Please wait a little more.
Flags: needinfo?(bugzilla)
Reporter

Comment 3

2 years ago
I've got reply and approval to use HTTPS and update the search domain/path from Yahoo Japan staff.

We need to change the search URL from:
http://auctions.search.yahoo.co.jp/search?p=SearchKeyWord&ei=EUC-JP&fr=mozff&rls=org.mozilla:ja-JP:official

to:
https://auctions.yahoo.co.jp/search/search?p=SearchKeyWord&ei=EUC-JP&fr=mozff&rls=org.mozilla:ja-JP:official

Please check and use this patch to do this.
Reporter

Updated

2 years ago
Attachment #8890151 - Flags: review?(francesco.lodolo)
Comment on attachment 8890151 [details] [diff] [review]
use HTTPS and update search url domain/path for Yahoo JP Auction

Please format the patch so that it can be submitted to m-c (e.g. using queue), or use mozreview. If you prefer, I can take over the patch submission, but a plain diff is not OK for review, since it's not actionable.
Attachment #8890151 - Flags: review?(francesco.lodolo)
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Attachment #8890151 - Attachment is obsolete: true
Assignee

Updated

2 years ago
Assignee: nobody → m_kato
Comment on attachment 8892251 [details]
Bug 1354511 - Use HTTPS and update domain/parameters for Yahoo! auction search plug-in.

https://reviewboard.mozilla.org/r/163200/#review168636

::: browser/locales/searchplugins/yahoo-jp-auctions.xml:10
(Diff revision 1)
>  <SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
>  <ShortName>ヤフオク!</ShortName>
>  <Description>ヤフオク! 検索</Description>
>  <InputEncoding>EUC-JP</InputEncoding>
>  <Image width="16" height="16">data:image/x-icon;base64,AAABAAIAEBAAAAEAIAAEAwAAJgAAACAgAAABACAARgcAACoDAACJUE5HDQoaCgAAAA1JSERSAAAAEAAAABAIBgAAAB/z/2EAAALLSURBVDiNfZNbSFRRFIb/dc4Zz2gz3iK1oFToJSPCpECoqBAiCPPFy0PFoBUlEWRmiFDjg4VmkYHdCDQIIiswM30IL5g6mQ1qeQuzcVQ0YWq00XScc87qQSfHAVsv+2Hv/1v/umxgjWBmWj4N9vdvzSNNr079u6uqEtfSrQD6qgKWAVGtN3Pmuouz2d5ef2YlwX8gbDYLAAgA2ooyTC9SjTMvD4EtRWd5tK0+28elIPnbbm4uFOmgWQXAlpJMk8s2UGHQheF3WLB7vOWBrDGXjzTXIOZA8j0i0iRfMREBgAIAlpJM06xtoMLj+AJN0HuCZKM8p210OxsfyiERm8pdo/29xi1xLZKPmL2wjzdMpmnbQIXH8RmaYPCwuE7Hs985InKXrO1Iap+ZcVTOOZ2DAEDMLBCRxsyBYx0Nub9GhvZMvLufRK5veg+FKhACJF4YcRui9snGuMTa3eeL04ho3ptYgtUqAtAAbPg11HvN3VImTk/YPOtCYzUBisTqgiouQp4XAhGTePTLslhcdq0ISEhQABARjUbGJ2Zp29NVvQLdgkdVFbcDsjQvRqRcH3YFx2rdzx7l27ss1wCoRKQ0NTVJq5YGAJy2AVNn+VWu2gt+c3InfyjLa2Tm4LE+6/nagtNcffkEj/Z0FKyauxkQ6uruygB0APBzeDDTUnqJe4rPsWPQetz7bry/+2J1fha/zjvJtm7LlaUmAkQAwy+mej9lT9u/xgfNTV3YnJYz7wvpfFJ2O8RoQPTh1IsEAE+PhAe71EW9qs6q4bHJkv1xzWI+4PRbMpGIVAAY6mjOsXW23orYui2XAKB0f+AdEoQMMCYAZT2k8K5LDZMpwNLHobQ01R/CzNEAxqgmPSpbJJTrRUDRAFEAmBl/1IBbx56P5QKAb5nevfE6k0DkAqhyEfjBIB0zKxojHOyZ9O8LluatMTPBapUKa2vVv/Q3b+fAt5TJAAAAAElFTkSuQmCCiVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAHDUlEQVRYha2Xa3AT1xXH/2f3rixZfie2eQ9JKK+EJinm0RRcPCkm00cSIKb1wDTNtIlJO3TSyfRLv7BpM518aHAmHejkVTJtEicycXAInYSXFGqoS+WkmJcfWEBpjI0B+SFZ2t27e/pBspGNBAZ6ZjQare4957f/87i7wG0aM6vJb0/0Qtci49LZeSn/0Y32K7cZnIjIZmZPtK97+3DHF0fO/6vppNHfvRYAAoEX1Nvxf0MLBoMaALA5+BPuaOY6wPy0uoBDn9WxTEL4/bqYiBK3ZKzrCgAwc9bh2uc/2LO+hBsfR/xvVUhC9K4FAPb51EwQ4nYAAggoAJyT23/9QP/5Y0v7oyay3bNcVuy0bHujWgB1O2R/9xNUMOVDXwLCISL+vwD4dV1U6Lpsr/vt8kunOw5khc8LZrYHYwNqXvYsYcVOy7Y3qwXw/g451LtW5JY2pIO4pdwEX3tGK6t53Tr5rl5+JdS5L3LKrxnGgCRRICKmhHRs5GXng2JdUgiIeU+/jxkPVawVuaUNzD6VaJ094uumuyA1eDjUuS96yq8ZRkSSVigAB15NgVBUDA4Pgt33CCkh2974Ef5z2P8hD/WuIVpn+3y+0e64KQVY1wXpukwG3xtpC7ji8SFJWp4A21fXMRC1HEjHRr63EBzrtFRAm1dTh5nLVm0QOUXvMrNCRM6EFfCPDb4v0uZ3xYxBS3HlC7Acs5YI8GqAJrIRDnfaInu2JnsB5UIXzMjAWgBAfT0B1ynCZNuoaGmhlpYWlNXUWFeDB7S4MWSpWoHGjnWNkMwOVOGFOxaSntIyIYru6HffeRc7xZO/8JR6fwwAqKpycM3Oq8EVInJSr3X6fv/ti+0n9kRO+V1xIyIVLV8wXxsc7ICEFzISsnKL5mqllU9HJs2dW1H8je8FmU+4iO41kxOU0wIwszoyXu34wAbV7RnuOXJAnN617dX4uZN5w8MXJWkjso/fziDFDTtyVuYW3ydKVz4VmfbgkoqCucuCmW5uTApSZrs72tf9tnPu+LpI3EJf51Fc+nIXlJwpTiK4nV48ErDNbsdb8oAoXv7EhekLFj6WP3dZMPjaM9onF6bYmzdv5vHKjvEy0qPG5XPzw63NJwKrf2grd4PjOSD1julKjiaJ0icNIAHVVYT4f1vljNW/Efeu3/RxdtHkx6oA1Ze4MyfdzjFdUF+f+HYVzYhw4bTI1J8+rGpTwYUz71eJoxQxHTjMYz2wA1LccKzLTuxMqxUWUA821qL90OeP2kb0d/WATUQOM6ftuHQ1oCQ3lPcc++fejjefc11ua7a0kvnaUKQXDAGvi6AQgdmBIryQQyHpLV4gJn2rGoHG7Rg+0Sm9ORCrtuzEPeWrdFXzvJDqO6MCAEBEjq7rChEdnLRgycrZP3vFLJqzVLMunrRyvSUgOIiaDIcdqCIbMhKS+SVfF6XLq7rnrHnqrys2/YELp0JYWbB2b3wcZ5r26rYR2zzie7wSGSdhMBjUysrKLGYu72lt3tfx1q+0K+3NUtw5RwxFrwCqG27rvJ1XNFudVFkTmb5w0cP5c8qPsG1uCv0j8Oqnz1fCJFi4BO37rzfi7uWV11UirfHIAwdzec/RZjOwaQl/tArWrg3z+J0fwN6x/j4++peXeqNdTWUA4NOrXMn1G0OH9/LWxeDapTBr54A79u9k24jpqam+IUByoRiBuNDabAQ2LeGPvgur4VHIv29+kge7zxwfUZOZFT2ZVmbeGDq0h7cuBW9ZDPOV+eDO/Y23COH3j0L0HG02P3+unN8Dhltf/iWHu47tGV2XgCAkU8vMz3Y17eFtD4FfXpiA6Ni/k20rURM3ZakQ3f8+FOve8Ufu3P3n/XzG705eH60nZqYUJZ7tOpSA2LI4kY7OA41sGddCkA4oDFC6j67rSkpNPGKGe9/hvr7cTFJeA9H0GW/9JnjLIhhb7gJ3BT5mM/zVgzevRPI9IOV3xjyOhwgllaj92lWA1LOA9Bs8oOgAJ88KBYGAghUr7Ou1ExExMwNEChH9iZnxnZd2b4O0MGPJSl3zeL4k/wqIigDk1sqcn8OhFwFcZEAQgZlHgWwCF4Bw8Bd7I1WceObgTIHTKDHa9xwfmGWYpurOK24HAFERgA0Ag8O2Z3KOWthvOIXKuBPHYSDHRbgSd2YCAAHsq4K6rh42JmDJCUhExOTOP50KJhpWTy3yZDvlPQPWIsu2keWCyeNGNAGOTXAVZJP3k+rCJ01Htqz5oPe4rkPRddx4omE0HYT6egVVAFDlEJEj1CyekaepDa5CBYZkBuDK5ISBedNylbfPDiovAjg+uRsqMDGAEQhgrGoCJO0BQ4DBYEb64z5pkoEBw4HiYBgAZndMvA4ymcjLyu4YNOT9ACBsi6XI/CLJNnHYIGFbzlcAsCIwsRq4nv0Phi4X5d/okEsAAAAASUVORK5CYII=</Image>
> -<Url type="text/html" method="GET" template="http://auctions.search.yahoo.co.jp/search" resultdomain="yahoo.co.jp">
> +<Url type="text/html" method="GET" template="https://auctions.search.yahoo.co.jp/search" resultdomain="yahoo.co.jp">

Can you confirm if this URL works for you? It doesn't for me.

https://auctions.search.yahoo.co.jp/search is stuck loading.

http://auctions.search.yahoo.co.jp/search (without https) redirects me to https://auctions.yahoo.co.jp/search/search, which loads immediately.

https://auctions.yahoo.co.jp/search/search?p=coffee works (double /search)

Searchform URL works fine.
Assignee

Comment 8

2 years ago
Ah, I mistake importing patch.  new patch is coming soon
Comment hidden (mozreview-request)
Comment on attachment 8892251 [details]
Bug 1354511 - Use HTTPS and update domain/parameters for Yahoo! auction search plug-in.

https://reviewboard.mozilla.org/r/163200/#review168648

Thanks, this works. Also going to land, maybe we can catch the merge.
Attachment #8892251 - Flags: review?(francesco.lodolo) → review+

Comment 11

2 years ago
Pushed by francesco.lodolo@mozillaitalia.org:
https://hg.mozilla.org/integration/autoland/rev/6639cc7b2321
Use HTTPS and update domain/parameters for Yahoo! auction search plug-in. r=flod

Comment 12

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6639cc7b2321
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Flags: needinfo?(bugzilla)
You need to log in before you can comment on or make changes to this bug.