1354519 - De-duplicate already ESLint recommended rules in toolkit/components/passwordmgr/.eslintrc.js

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Mark Banner (:standard8)]

We now have a recommend set of rules for ESLint in Mozilla, I'd like for us to tidy up duplicates, so that it is easier to see where modules/different areas are different.

This bug is to tidy up toolkit/components/passwordmgr/.eslintrc.js

I'm happy to mentor this.

Recommended rules: https://dxr.mozilla.org/mozilla-central/source/tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js

What needs doing (all in the file toolkit/components/passwordmgr/.eslintrc.js):

- Remove the extends section, as this is unnecessary (ESLint inherits rules through the directory tree).
- For the rules, globals and env sections, go through each one and compare to the recommended, then:
-- If it is the same (with the same parameters), remove the rule
-- If it is commented, remove it
-- If it is different, leave it in.
- Finally check ESLint still runs correctly (./mach eslint) and passes with no errors (warnings are ok if they are the same as previous).

Once that's done, attach a patch and request review from me (Standard8)

Comment 1

[Hemant Singh Patwal]

Hey I want to work on this bug.Can someone assign it to me please?

Comment 2

[Mark Banner (:standard8)]

I've just realised there's extra cleanup that can be done as well:

- If the .eslintrc.js file lists a rule as 'warn' and recommended.js lists it as 'error', then drop the rule in the .eslintrc.js file.

This will promote the rule to "error" which is better as it'll get fixed if it is an error, where as warnings tend to get ignored.

Comment 3

[Hemant Singh Patwal]

Thanks for info :).

Comment 4

[Hemant Singh Patwal]

Attachment: Bug 1354519 - De-duplicate already ESLint recommended rules in toolkit/components/passwordmgr/.eslintrc.js.

Review commit: https://reviewboard.mozilla.org/r/133494/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133494/

Comment 5

[Hemant Singh Patwal]

Hi Mark

Please have a look at the patch and direct me for changes(if needed).

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 8861526 [details]
Bug 1354519 - De-duplicate already ESLint recommended rules in toolkit/components/passwordmgr/.eslintrc.js.

https://reviewboard.mozilla.org/r/133494/#review136712

Thank you for the patch. Unfortunately this will need rebasing onto the latest code as another bug has added in a "complexity" rule (that will need to stay in).

Apart from that, just one minor issue to ensure ESLint keeps passing.

::: toolkit/components/passwordmgr/.eslintrc.js
(Diff revision 1)
> -
> -    // No using undeclared variables
> -    "no-undef": "error",
> -
> -    // Don't allow unused local variables unless they match the pattern
> -    "no-unused-vars": ["error", {"args": "none", "vars": "local", "varsIgnorePattern": "^(ids|ignored|unused)$"}],

`no-unused-vars` needs leaving in currently due to the different varsIgnorePattern.

Comment 7

[Hemant Singh Patwal]

Comment on attachment 8861526 [details]
Bug 1354519 - De-duplicate already ESLint recommended rules in toolkit/components/passwordmgr/.eslintrc.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/133494/diff/1-2/

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 8861526 [details]
Bug 1354519 - De-duplicate already ESLint recommended rules in toolkit/components/passwordmgr/.eslintrc.js.

https://reviewboard.mozilla.org/r/133494/#review137008

Thank you for the update. Looks good. r=Standard8

Comment 9

[Mark Banner (:standard8)]

I've triggered this to land, however it'll probably take a while as the trees are currently closed atm.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5cdda2e95bd7
De-duplicate already ESLint recommended rules in toolkit/components/passwordmgr/.eslintrc.js. r=standard8

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5cdda2e95bd7