1354529 - Generator functions created through GeneratorFunction are incorrectly created as constructors

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[André Bargull [:anba]]

Derived from https://github.com/tc39/test262/blob/master/test/built-ins/GeneratorFunction/instance-construct-throws.js:
---
var GeneratorFunction = Object.getPrototypeOf(function* () {}).constructor;
var instance = GeneratorFunction();
new instance();
---

Expected: Throws TypeError
Actual: No TypeError

Comment 1

[André Bargull [:anba]]

Attachment: bug1354529.patch

I don't think it matters whether async functions and async generators use INTERPRETED_LAMBDA_GENERATOR_OR_ASYNC or INTERPRETED_LAMBDA due to the wrapping. Is that correct?

Comment 2

[Tooru Fujisawa [:arai]]

Comment on attachment 8855779 [details] [diff] [review]
bug1354529.patch

Review of attachment 8855779 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

(In reply to André Bargull from comment #1)
> I don't think it matters whether async functions and async generators use
> INTERPRETED_LAMBDA_GENERATOR_OR_ASYNC or INTERPRETED_LAMBDA due to the
> wrapping. Is that correct?

correct.

just to be sure, this is tested by the test262 (maybe added in the next update?), right?

Comment 3

[André Bargull [:anba]]

(In reply to Tooru Fujisawa [:arai] from comment #2)
> (In reply to André Bargull from comment #1)
> > I don't think it matters whether async functions and async generators use
> > INTERPRETED_LAMBDA_GENERATOR_OR_ASYNC or INTERPRETED_LAMBDA due to the
> > wrapping. Is that correct?
> 
> correct.

Great!

> 
> just to be sure, this is tested by the test262 (maybe added in the next
> update?), right?

Yes, this is tested by https://github.com/tc39/test262/blob/master/test/built-ins/GeneratorFunction/instance-construct-throws.js (which is not yet in our local test262 copy). I've verified this test fails without the patch, and passes when the patch is applied.

Comment 4

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f573b326c4edde1d35189ac4c76e7493be39a4ca

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/448b205d97fd
Don't set constructor-flag for generator functions created through GeneratorFunction intrinsic. r=arai

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/448b205d97fd