Add a 'Pocket List' button to the Library panel

VERIFIED FIXED in Firefox 56

Status

()

Firefox
Toolbars and Customization
P1
normal
VERIFIED FIXED
4 months ago
14 days ago

People

(Reporter: mikedeboer, Assigned: Gijs)

Tracking

(Blocks: 2 bugs)

Trunk
Firefox 56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 verified)

Details

(Whiteboard: [photon-structure])

Attachments

(1 attachment)

50 bytes, text/x-github-pull-request
mixedpuppy
: review+
Details | Review | Splinter Review
(Reporter)

Description

4 months ago
The 'Pocket List' button is a new widget that will open the list of documents from the Pocket service when clicked. Its icon will be of the Pocket navbar button.
It's very similar to the button in the hamburger menu with the same name.

Please take a possible future hotkey assignment into account. (no pun intended.)

A separator is shown below this menu item.
(Reporter)

Updated

4 months ago
Blocks: 1354536
(Assignee)

Updated

4 months ago
No longer blocks: 1354536
No longer depends on: 1354533

Updated

4 months ago
Flags: qe-verify+
Priority: -- → P2
QA Contact: gwimberly
Whiteboard: [photon] → [photon-structure]
Just to clarify - this just takes you to the Pocket service page, as in the current implementation. No submenu showing Pocket'd items.
(Assignee)

Updated

2 months ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 56.1 - Jun 26
Priority: P2 → P1
(Assignee)

Comment 2

2 months ago
Created attachment 8878436 [details] [review]
Github PR
(Assignee)

Comment 3

2 months ago
Comment on attachment 8878436 [details] [review]
Github PR

Shane, not sure if you use flags on m-c or in github for pocket stuff, so just going with both - sorry for the spam!
Attachment #8878436 - Flags: review?(mixedpuppy)
Attachment #8878436 - Flags: review?(mixedpuppy) → review+

Comment 4

2 months ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c7ab6f816fa
add pocket item to photon library panel, r=mixedpuppy
(Assignee)

Comment 5

2 months ago
(This landed in github in https://github.com/mozilla-partners/pocket/pull/16#event-1127112775 - per discussion on IRC, I cross-landed in m-c.)
https://hg.mozilla.org/mozilla-central/rev/1c7ab6f816fa
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56

Comment 7

2 months ago
" 'Pocket List' button to the Library panel " feature has been implemented with Latest Nightly 56.0a1 on Windows 8.1 (64 bit).

Build ID : 20170618030207
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: [bugday-20170614]
Verified on Windows, Mac, and Ubuntu.
Status: RESOLVED → VERIFIED
status-firefox56: fixed → verified
Flags: qe-verify+
status-firefox55: affected → ---
Depends on: 1375806
(Assignee)

Updated

2 months ago
No longer depends on: 1375806
Blocks: 1387512
You need to log in before you can comment on or make changes to this bug.