Closed Bug 1354534 Opened 7 years ago Closed 7 years ago

Add a 'Pocket List' button to the Library panel

Categories

(Firefox :: Toolbars and Customization, enhancement, P1)

Product:
Firefox
Component:
Toolbars and Customization
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 56
Iteration:
56.1 - Jun 26
Tracking Flags:
Tracking Status
firefox56 --- verified

People

(Reporter: mikedeboer, Assigned: Gijs)

References

Details

(Whiteboard: [photon-structure])

Attachments

(1 file)

Github PR
50 bytes, text/x-github-pull-request
mixedpuppy
: review+
Details | Review 
The 'Pocket List' button is a new widget that will open the list of documents from the Pocket service when clicked. Its icon will be of the Pocket navbar button.
It's very similar to the button in the hamburger menu with the same name.

Please take a possible future hotkey assignment into account. (no pun intended.)

A separator is shown below this menu item.
Blocks: 1354536
No longer blocks: 1354536
No longer depends on: 1354533
Flags: qe-verify+
Priority: -- → P2
QA Contact: gwimberly
Whiteboard: [photon] → [photon-structure]
Just to clarify - this just takes you to the Pocket service page, as in the current implementation. No submenu showing Pocket'd items.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 56.1 - Jun 26
Priority: P2 → P1
Attached file Github PR — 

    
    

    
  
Comment on attachment 8878436 [details] [review]
Github PR

Shane, not sure if you use flags on m-c or in github for pocket stuff, so just going with both - sorry for the spam!

        Attachment #8878436 -
        Flags: review?(mixedpuppy)

        Attachment #8878436 -
        Flags: review?(mixedpuppy) → review+

    
    

    
  
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c7ab6f816fa
add pocket item to photon library panel, r=mixedpuppy

    
    

    
  
(This landed in github in https://github.com/mozilla-partners/pocket/pull/16#event-1127112775 - per discussion on IRC, I cross-landed in m-c.)

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/1c7ab6f816fa
Status: ASSIGNED → RESOLVED
Closed: 7 years ago

          status-firefox56:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56

    
    

    
  
" 'Pocket List' button to the Library panel " feature has been implemented with Latest Nightly 56.0a1 on Windows 8.1 (64 bit).

Build ID : 20170618030207
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: [bugday-20170614]

    
    

    
  
Verified on Windows, Mac, and Ubuntu.
Status: RESOLVED → VERIFIED

          status-firefox56:
          fixed → verified
Flags: qe-verify+
Depends on: 1375806

    
  
No longer depends on: 1375806

    
  
Blocks: 1387512

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: