Closed Bug 135454 Opened 22 years ago Closed 22 years ago

Should disable Send Unsent Messages if we are currently sending unsent messages

Categories

(MailNews Core :: Networking: SMTP, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Details

(Keywords: crash, Whiteboard: [ADT2])

Attachments

(1 file, 2 obsolete files)

spun off from bug 134624 - 

We should not allow Send Unsent Messages if we're already sending unsent
messages. Looking at the code, we could set a flag in the messenger object that
we're doing a send unsent and clear it when the send finishes, probably in the
send later listener, and then disable subsequent send unsent messages requests.
Marking nsbeta1+/ADT2 per ADT triage.
Keywords: crash, nsbeta1+
Whiteboard: [ADT2]
Attached patch proposed fix (obsolete) — Splinter Review
fix as described above. Unfortunately, ::OnStartSending never gets called, so
we have to set the sendingUnsentMsgs flag ourselves. I tried testing the stop
key and a non-existent server, but the stop key doesn't work, which I'll file
as another bug.
JF, can I get a review? thx.
Status: NEW → ASSIGNED
Comment on attachment 79479 [details] [diff] [review]
proposed fix

whoops, attaching failed.
Attachment #79479 - Attachment is obsolete: true
Attached patch trying again, proposed fix (obsolete) — Splinter Review
Comment on attachment 79480 [details] [diff] [review]
trying again, proposed fix

sr=sspitzer

assuming that it is by design that OnStartSending() isn't getting called, and
not a problem.

ducarroz, is that documented in the code?
Attachment #79480 - Flags: superreview+
I don't now if it's ok than OnStartSending is not called but that doesn't sound
right! Let me check...
Correct, we never call NotifyListenerOnStartSending which is suppose to call
OnStartSending and I don't know why. That is true for send and sendlater. I'll
file a bug for that for further investigation. But for now, David patch is fine.
Comment on attachment 79480 [details] [diff] [review]
trying again, proposed fix

r=ducarroz
Attachment #79480 - Flags: review+
new fix, using weak references, in case the send later object is never
destroyed, don't want to hold onto the messenger object.
Attachment #79480 - Attachment is obsolete: true
Comment on attachment 79493 [details] [diff] [review]
proposed fix using weak references

sr=sspitzer

ducarroz, when you log the bug about OnStartSending() not getting called, can
you fix bienvenu's comment
("// this never gets called :-(") to point to that bug?
Attachment #79493 - Flags: superreview+
fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
adding nsbeta1-.  Let's get this in the next release.
Keywords: nsbeta1+nsbeta1-
reassign->meehansqa
QA Contact: sheelar → meehansqa
nominating for Buffy
Keywords: nsbeta1-nsbeta1+
Tested using Trunk build 20020905, working correctly. Closing as VERIFIED.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: