1354595 - bugzilla: move '/rest` part of the URL into a new object property, `base_url`

Status: RESOLVED INCOMPLETE

(Conduit :: General, defect)

Description

[Piotr Zalewa [:zalun]]

::: commitindex/commitindex/reviews/bugzilla.py:97
(Diff revision 5)
>              BugzillaError: General error where the fault code and string will
>              pertain to the specific error code generated by Bugzilla.
>          """
>  
>          try:
> -            self.call('GET', '/bug/' + quote(str(bug_id)))
> +            self.call('GET', '/rest/bug/' + quote(str(bug_id)))

Not a blocker, but I suggest the `/rest` part of the URL get pulled into a new
object property, `base_url`, constructed of the hostname URL and the
api-specific component.  Then these calls can stay as-is.  self.call would do
the work to combine `self.base_url + path`.

Comment 1

[Piotr Zalewa [:zalun]]

Attachment: commitindex: move '/rest` part of the URL into a new object property, `base_url` (bug 1354595)

'/rest' is added to a rest_url. As the url is modified private property is used, to avoid confusion.

Review commit: https://reviewboard.mozilla.org/r/127742/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/127742/

Comment 2

[Israel Madueme [:imadueme]]

Outdated, no longer needed - there is no commitindex in the new commit pipeline architecture.