1354619 - Spammy "Cannot set transparency mode on non-popup windows" warning

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

I added that warning in bug 1344839, and apparently we're hitting it a lot on Linux.

Easiest solution is to remove the warning - but I would like to understand who or what is trying (and failing) to set the transparency on the window.

Comment 1

[Andrew McCreight [:mccr8]]

Judging from how frequently I see it this may be of interest to erahm.

It prints out the message once every time I move my mouse over the title bar or maybe tab strip.

I'm using Ubuntu.

Comment 2

[Lee Salzman [:lsalzman]]

Attachment: allow nsWindow::SetTransparencyMode when it preserves current mode

It looks like the caller in this case is just nsContainerFrame::SyncWindowProperties doing what is a no-op call to reset the transparency mode (https://dxr.mozilla.org/mozilla-central/source/layout/generic/nsContainerFrame.cpp?q=nsContainerFrame%3A%3ASyncWindowProperties&redirect_type=direct#609).

Just moving the warning down after the mIsTransparent == isTransparent check should remove the spamminess of this while letting the warning stay.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8857642 [details] [diff] [review]
allow nsWindow::SetTransparencyMode when it preserves current mode

Review of attachment 8857642 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, makes sense. Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1bde8c2a5dc9
allow nsWindow::SetTransparencyMode when it preserves current mode. r=mconley

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1bde8c2a5dc9

Comment 6

[Lee Salzman [:lsalzman]]

Comment on attachment 8857642 [details] [diff] [review]
allow nsWindow::SetTransparencyMode when it preserves current mode

Approval Request Comment
[Feature/Bug causing the regression]: bug 1344839, so 54+
[User impact if declined]: Excessive warning spam on Linux.
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no
[Why is the change risky/not risky?]: This does not change the semantics of the underlying code at all, and just silences a spammy warning on Linux.
[String changes made/needed]: none

Comment 7

[Gerry Chang [:gchang]]

Comment on attachment 8857642 [details] [diff] [review]
allow nsWindow::SetTransparencyMode when it preserves current mode

Fix an issue that generates excessive warning spam on Linux. Aurora54+.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ed4e7993e34d

Comment 9

[Jorg K (CEST = GMT+2)]

Nice, why didn't you fix it on Windows, too? See bug 1356575.

Comment 10

[Lee Salzman [:lsalzman]]

(In reply to Jorg K (GMT+2) from comment #9)
> Nice, why didn't you fix it on Windows, too? See bug 1356575.

This was fixed in a general way for all platforms, but the underlying "problem" was benign on Linux, so that the fix merely happened to silence the warning there. If other platforms are still triggering, then have a real bug that is unrelated to this particular.