1354642 - Add MakeRefPtr.

Status: RESOLVED FIXED

(Core :: MFBT, enhancement)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

I was reviewing some code in bug 1320994 comment 22 which could really have used a MakeRefPtr:

> RefPtr<Refcountable<UniquePtr<OnTracksAvailableCallback>>> tracksAvailableCallback =
>     MakeAndAddRef<Refcountable<UniquePtr<OnTracksAvailableCallback>>>(
>         mManager, mOnSuccess, mWindowID, domStream);

With MakePtr it would be a svelte:
> auto tracksAvailableCallback = MakeRefPtr<Refcountable<UniquePtr<OnTracksAvailableCallback>>>(
>     mManager, mOnSuccess, mWindowID, domStream);

I saw mention of MakeRefPtr in bug 1208262 comment 10, and ehsan ok'ed reviewing a patch for it on irc. Thanks!

I don't think we need to convert the world or anything, but it sure helps with those really long ones.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1354642 - Add MakeRefPtr<> helper class.

Review commit: https://reviewboard.mozilla.org/r/127796/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/127796/

Comment 2

[(no longer active)]

Comment on attachment 8855912 [details]
Bug 1354642 - Add MakeRefPtr<> helper class.

https://reviewboard.mozilla.org/r/127796/#review135396

Thanks for the patch, and sorry for the long delay..

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8855912 [details]
Bug 1354642 - Add MakeRefPtr<> helper class.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/127796/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66bfd5c79d98
Add MakeRefPtr<> helper class. r=Ehsan

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/66bfd5c79d98