135469 - Missing version in show/dependency-graph.html.tmpl (tree is a-burinin')

Status: RESOLVED FIXED

(Bugzilla :: Reporting/Charting, defect)

Description

[David D. Kilzer (ddk)]

Template checked in for Bug 126793 was missing a version,
and set the tinderbox tree on fire.  Simple patch to
follow.

Comment 1

[David D. Kilzer (ddk)]

Target 2.16.  Add CCs.  Add keywords: patch, review.
Assigning to me.

Comment 2

[David D. Kilzer (ddk)]

Attachment: Patch v.1

Add version to template/default/show/dependency-graph.html.tmpl.

Comment 3

[Gervase Markham [:gerv]]

Comment on attachment 77680 [details] [diff] [review]
Patch v.1

I think Zach decided to leave out the HTML comments and/or use TT ones. He's
got a bug open somewhere...

Gerv

Comment 4

[Zach Lipton [:zach]]

No, html comments are what we want for html templates. However, we 
don't want html comments in txt templates and the like because it means 
that the literal comment string is printed and emailed to the user so we 
use TT comments. html comments are fine for this.

Comment 5

[Zach Lipton [:zach]]

Comment on attachment 77680 [details] [diff] [review]
Patch v.1

r=zach x2

Comment 6

[Gervase Markham [:gerv]]

Zach: can you please post the final format to reviewers@ or to the newsgroups,
please? I have other templates to check in soon, and don't want to set the tree
on fire again.

Gerv

Comment 7

[David D. Kilzer (ddk)]

Gerv:

For HTML-based templates:
<!-- [e-mail] -->

For non-HTML-based templates:
[%# [e-mail] %]

Should there be a documentation bug filed for this (hacker's guide
perhaps)?

Comment 8

[David D. Kilzer (ddk)]

Added notes to Bug 107917 regarding template versioning info.

Comment 9

[Gervase Markham [:gerv]]

Fixed. Let's get that tree green :-)

Checking in template/default/show/dependency-graph.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/default/show/dependency-graph.html.tmpl,v
 <--  dependency-graph.html.tmpl
new revision: 1.2; previous revision: 1.1
done

Gerv