1354730 - Disable named property object visibility on Xrays across the board once 57 ships

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement, P2)

Description

[Boris Zbarsky [:bzbarsky]]

Bug 1353150 is disabling it for webextensions.  But we want to do this in general.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Disable named property object (aka global scope polluter) behavior for all Xrays

MozReview-Commit-ID: KmbXFfSzH0N

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/518baff0f991
Disable named property object (aka global scope polluter) behavior for all Xrays.  r=kmag

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c3368c7a937b
followup.  Update out-of-date assertions to fix bustage and reopen CLOSED TREE.

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f55670929a2e
Back out to reopen CLOSED TREE.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: With some test fixes to the tests that were relying on the old behavior

Comment 6

[Kris Maglione [:kmag]]

Comment on attachment 8919142 [details] [diff] [review]
With some test fixes to the tests that were relying on the old behavior

Review of attachment 8919142 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay. I've been sick most of the week. r=me

Comment 7

[Boris Zbarsky [:bzbarsky]]

I happens.  It's not like I was particularly blocked on this.  I hope you're feeling better!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd06b3b18448
Disable named property object (aka global scope polluter) behavior for all Xrays.  r=kmag

Comment 9

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bd06b3b18448