1354761 - Intermittent browser/base/content/test/popupNotifications/browser_popupNotification_keyboard.js | Found an unexpected tab at the end of test run: http://example.com/ -

Status: RESOLVED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=89542762&repo=mozilla-inbound

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win64-debug/1491568296/mozilla-inbound_win8_64-debug_test-mochitest-e10s-browser-chrome-5-bm111-tests1-windows-build313.txt.gz

Comment 1

[Intermittent Failures Robot]

29 failures in 894 pushes (0.032 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 17
* mozilla-inbound: 7
* mozilla-central: 3
* try: 1
* graphics: 1

Platform breakdown:
* windows8-64: 10
* osx-10-10: 10
* windows7-32-vm: 8
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1354761&startday=2017-04-10&endday=2017-04-16&tree=all

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

this started on April 7th, seems to be debug e10s on all OS except linux.

I see recent changes to this test file in bug 1334496.

:johann, could you take a quick look at this and see if your recent changes are related to this failure?

Comment 3

[Johann Hofmann [:johannh]]

Yeah, maybe I know the solution, I think it was just an oversight.

Comment 4

[Johann Hofmann [:johannh]]

Attachment: Bug 1354761 - Avoid calling goNext inside BTU.withNewTab in browser_popupNotification_keyboard.js.

This was likely the cause of intermittent failures reporting dangling tabs at the end of the test.

Review commit: https://reviewboard.mozilla.org/r/132048/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132048/

Comment 5

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b8c6fbf13e7e1d24cee00ef785edc087c354b72c

Comment 6

[Intermittent Failures Robot]

27 failures in 817 pushes (0.033 failures/push) were associated with this bug in the last 7 days. 

This is the #40 most frequent failure this week.  

Repository breakdown:
* autoland: 9
* mozilla-inbound: 8
* mozilla-central: 6
* try: 2
* graphics: 2

Platform breakdown:
* osx-10-10: 16
* windows7-32-vm: 8
* windows8-64: 2
* linux64-nightly: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1354761&startday=2017-04-17&endday=2017-04-23&tree=all

Comment 7

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8860022 [details]
Bug 1354761 - Avoid calling goNext inside BTU.withNewTab in browser_popupNotification_keyboard.js.

https://reviewboard.mozilla.org/r/132048/#review135724

Comment 8

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8860022 [details]
Bug 1354761 - Avoid calling goNext inside BTU.withNewTab in browser_popupNotification_keyboard.js.

https://reviewboard.mozilla.org/r/132048/#review135726

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b3e94b9d4fe
Avoid calling goNext inside BTU.withNewTab in browser_popupNotification_keyboard.js. r=Nihanth

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2b3e94b9d4fe

Comment 11

[Intermittent Failures Robot]

6 failures in 883 pushes (0.007 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 3
* try: 2
* mozilla-central: 1

Platform breakdown:
* windows7-32-vm: 3
* osx-10-10: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1354761&startday=2017-04-24&endday=2017-04-30&tree=all