http urls in browser.dtd

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
Application Update
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: rstrong, Assigned: dthayer)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Followup to bug 893505

Comment on attachment 8822729 [details]
Bug 893505 - Simplify the application update UI

https://reviewboard.mozilla.org/r/100222/#review130562

::: browser/locales/en-US/chrome/browser/browser.dtd:904
(Diff revision 34)
>  <!ENTITY emeLearnMoreContextMenu.label            "Learn more about DRM…">
>  <!ENTITY emeLearnMoreContextMenu.accesskey        "D">
> +
> +<!ENTITY updateAvailable.message "Update your &brandShorterName; for the latest in speed and privacy.">
> +<!ENTITY updateAvailable.whatsnew.label "See what’s new.">
> +<!ENTITY updateAvailable.whatsnew.href "http://www.mozilla.org/">

This really shouldn't be http://

More important, why are you exposing this as a localizable value? I'm quite sure you don't want people to change it

::: browser/locales/en-US/chrome/browser/browser.dtd:914
(Diff revision 34)
> +<!ENTITY updateAvailable.cancelButton.accesskey "N">
> +<!ENTITY updateAvailable.panelUI.label "Download &brandShorterName; update">
> +
> +<!ENTITY updateManual.message "Download a fresh copy of &brandShorterName; and we’ll help you to install it.">
> +<!ENTITY updateManual.whatsnew.label "See what’s new.">
> +<!ENTITY updateManual.whatsnew.href "http://www.mozilla.org/">

Same issue here
Comment hidden (mozreview-request)
There one unanswered question: why are you exposing this URL as a localizable value?
(Reporter)

Comment 3

10 months ago
mozreview-review
Comment on attachment 8856626 [details]
Bug 1354774 - http URLs in browser.dtd for appUpdate

https://reviewboard.mozilla.org/r/128574/#review131002

I think that should use the update.detailsURL similar to https://bugzilla.mozilla.org/show_bug.cgi?id=893505#c89
Attachment #8856626 - Flags: review?(robert.strong.bugs) → review-
Comment hidden (mozreview-request)
(Reporter)

Comment 5

10 months ago
mozreview-review
Comment on attachment 8856626 [details]
Bug 1354774 - http URLs in browser.dtd for appUpdate

https://reviewboard.mozilla.org/r/128574/#review131008
Attachment #8856626 - Flags: review?(robert.strong.bugs) → review+

Comment 6

10 months ago
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9f19899f629b
http URLs in browser.dtd for appUpdate r=rstrong
(In reply to Francesco Lodolo [:flod] from comment #2)
> There one unanswered question: why are you exposing this URL as a
> localizable value?

It was overlooked and should have been removed since they aren't used.
(Assignee)

Updated

10 months ago
Assignee: nobody → dothayer

Comment 8

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9f19899f629b
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.