Closed Bug 1354842 Opened 6 years ago Closed 6 years ago

Don't adjust marker times in subprocess profiles during Talos symbolication

Categories

(Core :: Gecko Profiler, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(1 file)

This was done in bug 1255911, but it's no longer necessary because perf.html does the correct adjustment now.
Comment on attachment 8856136 [details]
Bug 1354842 - Back out bug 1255911 because the subprocess marker time adjustment is now done in perf.html.

https://reviewboard.mozilla.org/r/128080/#review130594

Is treeherder now pointing at perf-html.io for Talos profiles?
Attachment #8856136 - Flags: review?(mconley) → review+
It's not. That's a good point, I hadn't really thought about that.

However, it seems like cleopatra.io can no longer deal with the profiles that Talos generates anyway. I've filed https://github.com/devtools-html/perf.html/issues/255 to make perf.html work for this case, and then we can switch treeherder over.
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/7e3027ae80a0
Back out bug 1255911 because the subprocess marker time adjustment is now done in perf.html. r=mconley
https://hg.mozilla.org/mozilla-central/rev/7e3027ae80a0
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.