Closed Bug 1354886 Opened 6 years ago Closed 6 years ago

stylo: layout/reftests/css-display/display-contents-shadow-dom-1.html asserts parent on StyleNewChildren()

Categories

(Core :: CSS Parsing and Computation, enhancement, P5)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: emilio, Unassigned)

References

Details

Attachments

(1 file)

Bug 1354886: null-check parent in FrameConstructor::StyleNewChildren.
59 bytes, text/x-review-board-request
heycam
: review+
Details 
This is because we're inserting content into a shadow root which isn't part of the flat tree (because it doesn't match any insertion point).
Priority: -- → P3
We've determined that we don't need shadow dom support in the stylo timeframe.
Priority: P3 → P4
Priority: P4 → P5
Comment on attachment 8856338 [details]
Bug 1354886: null-check parent in FrameConstructor::StyleNewChildren.

https://reviewboard.mozilla.org/r/128236/#review130770
Attachment #8856338 - Flags: review?(cam) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a3aa7b8827ce
null-check parent in FrameConstructor::StyleNewChildren. r=heycam
https://hg.mozilla.org/mozilla-central/rev/a3aa7b8827ce
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.