stylo: layout/reftests/css-display/display-contents-shadow-dom-1.html asserts parent on StyleNewChildren()

RESOLVED FIXED in Firefox 55

Status

()

P5
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: emilio, Unassigned)

Tracking

(Blocks: 1 bug)

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
This is because we're inserting content into a shadow root which isn't part of the flat tree (because it doesn't match any insertion point).
Priority: -- → P3
We've determined that we don't need shadow dom support in the stylo timeframe.
Priority: P3 → P4
Priority: P4 → P5
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8856338 [details]
Bug 1354886: null-check parent in FrameConstructor::StyleNewChildren.

https://reviewboard.mozilla.org/r/128236/#review130770
Attachment #8856338 - Flags: review?(cam) → review+

Comment 4

2 years ago
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a3aa7b8827ce
null-check parent in FrameConstructor::StyleNewChildren. r=heycam

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a3aa7b8827ce
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.