1354887 - block lists (basic/strict) dialog gone, can't select strict, but localization is still implemented

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Darkspirit]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170408100422

Steps to reproduce:

(the new) about:preferences#privacy -> Tracking Protection


Actual results:

the block list selection dialog is gone, but localization for it is still implemented as we can see here:
https://dxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/preferences/preferences.properties#47
https://dxr.mozilla.org/mozilla-central/source/modules/libpref/init/all.js#5255


Expected results:

I think that the button was removed by mistake.

Comment 1

[Loic]

Jared, is it expected the buttons about exceptions and block list have disappeared after bug 1335907?

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

These should not have been removed. Thank you for reporting this issue.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1354887 - The Tracking Protection exceptions and block list dialogs should always be visible within the tracking protection section.

Review commit: https://reviewboard.mozilla.org/r/128898/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128898/

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

I searched through the other /browser/components/preferences/in-content/*.xul files to see if there were other hidden sections like this but didn't find any.

Comment 5

[Darkspirit]

I was surprised that bug 1286656 wasn't fixed with the nice rearrangement of the settings page. Maybe you could fix this next? I just want to unterline that the OK button of the Do No Track widget is cut off in the lower half on my Nightly/Debian testing+KDE as before the rearrangement.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8856983 [details]
Bug 1354887 - The Tracking Protection exceptions and block list dialogs should always be visible within the tracking protection section.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/128898/diff/1-2/

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8856983 [details]
Bug 1354887 - The Tracking Protection exceptions and block list dialogs should always be visible within the tracking protection section.

https://reviewboard.mozilla.org/r/128898/#review131584

Comment 8

[Marcia Knous [:marcia]]

Tracking 55+ to restore the missing button.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5806665ad3a4
The Tracking Protection exceptions and block list dialogs should always be visible within the tracking protection section. r=mconley

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5806665ad3a4

Comment 11

[Saddam Hossain]

I have reproduced this Bug on 55.0a1 (2017-04-09) on Windows 10, 64 Bit!

The bug's fix is now verified on latest  55.0a1

Nightly 55.0a1:
Build ID 	20170420030346
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170419]