Closed Bug 1354887 Opened 5 years ago Closed 5 years ago

block lists (basic/strict) dialog gone, can't select strict, but localization is still implemented

Categories

(Firefox :: Preferences, defect)

55 Branch
x86_64
Linux
defect
Not set
major

Tracking

()

VERIFIED FIXED
Firefox 55
Tracking Status
firefox52 --- unaffected
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 + verified

People

(Reporter: jan, Assigned: jaws)

References

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170408100422

Steps to reproduce:

(the new) about:preferences#privacy -> Tracking Protection


Actual results:

the block list selection dialog is gone, but localization for it is still implemented as we can see here:
https://dxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/preferences/preferences.properties#47
https://dxr.mozilla.org/mozilla-central/source/modules/libpref/init/all.js#5255


Expected results:

I think that the button was removed by mistake.
Severity: normal → major
Component: Untriaged → Tracking Protection
OS: Unspecified → Linux
Hardware: Unspecified → x86_64
Jared, is it expected the buttons about exceptions and block list have disappeared after bug 1335907?
Blocks: 1335907
Component: Tracking Protection → Preferences
Flags: needinfo?(jaws)
See Also: → 1286656
These should not have been removed. Thank you for reporting this issue.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(jaws)
Assignee: nobody → jaws
Status: NEW → ASSIGNED
I searched through the other /browser/components/preferences/in-content/*.xul files to see if there were other hidden sections like this but didn't find any.
I was surprised that bug 1286656 wasn't fixed with the nice rearrangement of the settings page. Maybe you could fix this next? I just want to unterline that the OK button of the Do No Track widget is cut off in the lower half on my Nightly/Debian testing+KDE as before the rearrangement.
Comment on attachment 8856983 [details]
Bug 1354887 - The Tracking Protection exceptions and block list dialogs should always be visible within the tracking protection section.

https://reviewboard.mozilla.org/r/128898/#review131584
Attachment #8856983 - Flags: review?(mconley) → review+
Tracking 55+ to restore the missing button.
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5806665ad3a4
The Tracking Protection exceptions and block list dialogs should always be visible within the tracking protection section. r=mconley
https://hg.mozilla.org/mozilla-central/rev/5806665ad3a4
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
I have reproduced this Bug on 55.0a1 (2017-04-09) on Windows 10, 64 Bit!

The bug's fix is now verified on latest  55.0a1

Nightly 55.0a1:
Build ID 	20170420030346
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170419]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.