Make ProfileGatherer grab the profile of the parent process on a background thread

RESOLVED INVALID

Status

()

Core
Gecko Profiler
RESOLVED INVALID
8 months ago
8 months ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 affected)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Assignee)

Description

8 months ago
I'm going to attach a few patches that make us call the profile gathering functions on a background thread. This is in preparation for bug 1330185, which will hopefully create a communication channel from a background thread in the parent process to a background thread on each other process.

Generating the JSON for the parent process profile on a background thread might be a good thing to do anyway, in order to reduce the jank that occurs during profile gathering. However, as is, these patches don't help much with the jank because the main thread sooner or later calls a function that accesses the profiler state, like profiler_is_active(), and then it just blocks until the background thread is done with the profile collection.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 4

8 months ago
This makes things too complicated and isn't worth doing at this point. I'm going to go ahead with keeping the collection of the *parent process* profile on its main thread, and only do profile collection for *content processes* on a background thread.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.