1354993 - [Firefox for Android] Add PictureID into VP8 CodecSpecificInfo

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P2)

Comment 1

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

Attachment: Bug 1354993 - Add PictureID into VP8 CodecSpecificInfo.

Review commit: https://reviewboard.mozilla.org/r/128284/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128284/

Comment 2

[John Lin [:jhlin][:jolin]]

Comment on attachment 8856358 [details]
Bug 1354993 - Add PictureID into VP8 CodecSpecificInfo.

https://reviewboard.mozilla.org/r/128284/#review131272

::: media/webrtc/signaling/src/media-conduit/WebrtcMediaCodecVP8VideoCodec.cpp:49
(Diff revision 1)
>  class CallbacksSupport final : public JavaCallbacksSupport
>  {
>  public:
>    CallbacksSupport(webrtc::EncodedImageCallback* aCallback) :
>      mCallback(aCallback),
> -    mCritSect(webrtc::CriticalSectionWrapper::CreateCriticalSection()) {
> +    mCritSect(webrtc::CriticalSectionWrapper::CreateCriticalSection()),

Coding style:
```Constructor()
  : init1
  , init2
  , ...
{
  ...```

Comment 3

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

Comment on attachment 8856358 [details]
Bug 1354993 - Add PictureID into VP8 CodecSpecificInfo.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/128284/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b1e46c6afa0
Add PictureID into VP8 CodecSpecificInfo. r=jolin

Comment 5

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/8b1e46c6afa0