Open Bug 1355015 Opened 5 years ago Updated 3 years ago

Investigate why audio stream fail to open the first time 3.5% of the time in 52

Categories

(Core :: Audio/Video: cubeb, enhancement, P3)

53 Branch
enhancement

Tracking

()

REOPENED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: padenot, Assigned: padenot)

References

Details

Attachments

(1 file)

Assignee: nobody → padenot
https://metrics.mozilla.com/firefox-hardware-report/#goto-os-and-architecture shows a very very big drop in Windows XP users recently.
Rank: 21
Priority: -- → P2
Comment on attachment 8856475 [details]
Bug 1355015 - Enable AUDIOSTREAM_BACKEND_USED up to version 60.

Benjamin, f? for this version bump. This serve two purposes:
- We know that a number of popular linux distribution are enabling telemetry in their binaries, and that a number of firefox packagers are compiling with Alsa support in. This will allow us to make sure our claim that only a minuscule portion of the linux population is true.
- We're seeing an seven-fold increase in error when an audio stream is opened for the first time in a process on Windows. The code itself has not changed a lot (almost nothing) in this period of time. This might be because of a population shift from old windows versions to more recent windows version. We'll add more ways of diagnosing this (and you might hear about us soon, because it might involve data collection), so that, if/when we try to fix it, we can have some data that shows the fix is working/not working.
Attachment #8856475 - Flags: review?(kinetik)
Attachment #8856475 - Flags: review?(benjamin)
Attachment #8856475 - Flags: feedback?(benjamin)
Comment on attachment 8856475 [details]
Bug 1355015 - Enable AUDIOSTREAM_BACKEND_USED up to version 60.

https://reviewboard.mozilla.org/r/128424/#review131034
Attachment #8856475 - Flags: review?(kinetik) → review+
Comment on attachment 8856475 [details]
Bug 1355015 - Enable AUDIOSTREAM_BACKEND_USED up to version 60.

https://reviewboard.mozilla.org/r/128424/#review131590
Attachment #8856475 - Flags: review+
Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/autoland/rev/3f399e180a22
Enable AUDIOSTREAM_BACKEND_USED up to version 60. r=bsmedberg,kinetik
Attachment #8856475 - Flags: feedback?(benjamin)
https://hg.mozilla.org/mozilla-central/rev/3f399e180a22
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Let's keep this open, I haven't got to doing an analysis of the number just yet.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Here is a bit of analysis on the percentage of time a Firefox fails to open an audio stream _for the first time in the lifetime of the content process_.

win version | 51 e10s | 51 non-e10s | 52 e10s | 52 non-e10s
    7       |   1.17  |    0.52     |  10.25  |    1.07
  8 & 8.1   |   0.73  |    0.34     |   0.98  |    0.93
   10       |   0.33  |    0.19     |   0.49  |    0.22

- e10s fails more often than non e10s.
- More recent version of Windows fail less than older version of Windows.
- Firefox 52 on Windows 7, with e10s is crazy and skews the number, we need to look into it. 
- Digging a bit deeper, it's specifically 32bits Firefox, with e10s enabled, running on Windows 7, trying to open an audio stream from a content process. 64bit Firefox show normal number.

Of course, it appears that this is the configuration where the number of users is the highest, or in any case a quite common configuration, it seems.
Mass change P2->P3 to align with new Mozilla triage process.
Priority: P2 → P3
See Also: → 1443528
Looking quite good at the minute.
You need to log in before you can comment on or make changes to this bug.