Closed Bug 1355023 Opened 7 years ago Closed 7 years ago

Run an extra tp5-sequential job on Talos for linux64-stylo

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Platform:
x86_64
Linux
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: shinglyu, Unassigned)

References

(Blocks 1 open bug)

Details

Currently Talos runs on real machine, has 8 CPU cores and stylo runs 6 threads.

Other tests like reftest runs in docker container, which has 2 cores and s-tylo runs 2 threads.

It makes sense to run all the tests in both sequential and parallel mode. For Talos we want to know the performance under different number of threads. For normal tests we want to catch parallel styling bugs, which we miss completely now. 

I'm thinking about split tests into two categories like reftest => reftest-sequential & reftest-parallel, but I'm not sure if that is acceptable in terms of budget and productivity.
For the non-performance tests, I think we're covered by bug 1318187.

For Talos, I think we should default to parallel, but it would be helpful to add an additional tp5 job to linux64-stylo. The extra automation cost for that single job on the linux64-stylo Talos tests (which only run on m-c) should be negligible.
Blocks: stylo-tooling
No longer blocks: stylo
Summary: stylo: Run sequential vs parallel tests on try → Run an extra tp5-sequential job on Talos for linux64-stylo
Priority: -- → P4
It looks like we currently run Talos (d g3 g4) for both e10s and non-e10s on m-c. We probably don't need to run Talos on non-e10s, since rel eng will retire all non-e10s tests with 57. Would replacing the non-e10s Talos run with e10s+sequential mode be adequate for this bug?
Flags: needinfo?(slyu)
Yes, that sounds like a great plan.
Flags: needinfo?(slyu)
Kim, it looks like we currently run Talos (d g3 g4) for Stylo with both e10s and non-e10s on m-c. We don't need to run Talos on non-e10s. We'd like to replace that Stylo non-e10s run with an "e10s + Stylo sequential mode" run, like bug 1356122.

Can you please make this Talos change after you fix bug 1356122?
Depends on: 1356122
Flags: needinfo?(kmoir)
opened bug 1358562 for this request
Flags: needinfo?(kmoir)
Ok, looks like the only thing left to do here is to enable Talos for |linux64-stylo-sequential opt|. Kim, can you take care of this? Much appreciate all the help here.
Flags: needinfo?(kmoir)
Blocks: 1363420
opened bug 1363420 for this request
Flags: needinfo?(kmoir)
The sequential Stylo Talos tests were enabled in bug 1363420, but the results won't be shown on Treeherder until bug 1365128 is fixed.
Status: NEW → RESOLVED
Closed: 7 years ago
Depends on: 1365128
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.