Closed
Bug 1355025
Opened 7 years ago
Closed 7 years ago
BytecodeEmitter::isRestParameter can be simplified now that it's no longer fallible
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
|
4.38 KB,
patch
|
arai
:
review+
|
Details | Diff | Splinter Review |
BytecodeEmitter::isRestParameter() always returns `true`, so we can replace the `result` out-param and instead directly return the boolean result.
|
Assignee | |
Comment 1•7 years ago
|
||
I've also dropped the MOZ_MUST_USE because isRestParameter is no longer fallible.
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8856451 -
Flags: review?(arai.unmht)
|
||
Updated•7 years ago
|
Attachment #8856451 -
Flags: review?(arai.unmht) → review+
|
|
Assignee | |
Comment 2•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b84849a1160cb1833a23daf1fb2b97b551da091e
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/540fcd0fa44e Directly return result instead of using out-param in BytecodeEmitter::isRestParameter. r=arai
Keywords: checkin-needed
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/540fcd0fa44e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•