Closed Bug 1355027 Opened 3 years ago Closed 3 years ago

Pushing to try with --artifact uses a non-asan build on linux64-asan

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jgraham, Assigned: chmanchester)

References

Details

Attachments

(1 file)

If you do |mach try -p linux64-asan -u <something> --artifact| the build successfully completes, but the tests are run on a non-asan build, thus giving misleading results. Since --artifact is implied by your mozconfig it's very easy to do this by accident.

Ideally this would work as one would expect, but failing that it would be better to ignore the --artifact flag on this platform.
Flags: needinfo?(cmanchester)
I think we have the exact same issue with stylo builds in bug 1349180.
Yeah this is happening for stylo builds as well. In general people developing Firefox front end features probably don't care about these build variants but there is potential value for people iterating on test related changes.

In both cases we may be able to just tweak the job selection code in artifacts.py and little else. I'll give that a try quickly.
Flags: needinfo?(cmanchester)
See Also: → 1349180
Actually that's not going to work, because the configure bits associated with these options are either skipped or fail when there isn't a compile environment around.
Yeah, I guess the thing to do is to not override the build variant in mozharness if the original build variant isn't a vanilla debug or opt build.
Assignee: nobody → cmanchester
Comment on attachment 8856766 [details]
Bug 1355027 - Don't attempt an artifact build for an asan build with --artifact in try syntax.

https://reviewboard.mozilla.org/r/128694/#review131164

Pretty thrilled to see this get used :)
Attachment #8856766 - Flags: review?(nalexander) → review+
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d30fe280e201
Don't attempt an artifact build for an asan build with --artifact in try syntax. r=nalexander
https://hg.mozilla.org/mozilla-central/rev/d30fe280e201
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Blocks: 1357562
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.