1355027 - Pushing to try with --artifact uses a non-asan build on linux64-asan

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[James Graham [:jgraham]]

If you do |mach try -p linux64-asan -u <something> --artifact| the build successfully completes, but the tests are run on a non-asan build, thus giving misleading results. Since --artifact is implied by your mozconfig it's very easy to do this by accident.

Ideally this would work as one would expect, but failing that it would be better to ignore the --artifact flag on this platform.

Comment 1

[Nathan Froyd [:froydnj]]

I think we have the exact same issue with stylo builds in bug 1349180.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Yeah this is happening for stylo builds as well. In general people developing Firefox front end features probably don't care about these build variants but there is potential value for people iterating on test related changes.

In both cases we may be able to just tweak the job selection code in artifacts.py and little else. I'll give that a try quickly.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Actually that's not going to work, because the configure bits associated with these options are either skipped or fail when there isn't a compile environment around.

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Yeah, I guess the thing to do is to not override the build variant in mozharness if the original build variant isn't a vanilla debug or opt build.

Comment 5

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1355027 - Don't attempt an artifact build for an asan build with --artifact in try syntax.

Our configs and the artifact machinery aren't equipped to handle this.

Review commit: https://reviewboard.mozilla.org/r/128694/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128694/

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8856766 [details]
Bug 1355027 - Don't attempt an artifact build for an asan build with --artifact in try syntax.

https://reviewboard.mozilla.org/r/128694/#review131164

Pretty thrilled to see this get used :)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d30fe280e201
Don't attempt an artifact build for an asan build with --artifact in try syntax. r=nalexander

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d30fe280e201