Closed
Bug 1355037
Opened 9 years ago
Closed 9 years ago
C++ tools throw errors on Windows
Categories
(NSS :: Libraries, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
3.32
People
(Reporter: franziskus, Assigned: lee.rinrire)
References
Details
(Keywords: good-first-bug)
Attachments
(1 file, 1 obsolete file)
|
1.90 KB,
patch
|
franziskus
:
review+
|
Details | Diff | Splinter Review |
> c:\users\franziskus\nss-dev\nss\cpputil\databuffer.h(49): error C2589: '(': illegal token on right side of '::'
> c:\users\franziskus\nss-dev\nss\cpputil\databuffer.h(49): error C2059: syntax error: '::'
> c:\users\franziskus\nss-dev\nss\cpputil\databuffer.h(129): error C2589: '(': illegal token on right side of '::'
> c:\users\franziskus\nss-dev\nss\cpputil\databuffer.h(129): error C2059: syntax error: '::'
> c:\users\franziskus\nss-dev\nss\cpputil\databuffer.h(136): error C2589: '(': illegal token on right side of '::'
> c:\users\franziskus\nss-dev\nss\cpputil\databuffer.h(136): error C2059: syntax error: '::'
The solution is to use (std::min)(whatever) instead of std::min(whatever).
First-good-bug submit.
Attachment #8857955 -
Flags: review?(franziskuskiefer)
|
Reporter | |
Updated•9 years ago
|
Assignee: nobody → lee.rinrire
|
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8857955 [details] [diff] [review]
bug1355037.patch - add required parentheses
Review of attachment 8857955 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good. Thanks for the patch! I'll go ahead and land it.
Attachment #8857955 -
Flags: review?(franziskuskiefer) → review+
|
|
Reporter | |
Comment 3•9 years ago
|
||
Oh, this is against the Firefox repository. Can you upload a patch against the NSS upstream repo https://hg.mozilla.org/projects/nss/?
Flags: needinfo?(lee.rinrire)
Sorry for previous patch. Hope this is the good one.
Flags: needinfo?(lee.rinrire)
Attachment #8859134 -
Flags: review?(franziskuskiefer)
|
|
Reporter | |
Updated•9 years ago
|
Attachment #8857955 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 5•9 years ago
|
||
Comment on attachment 8859134 [details] [diff] [review]
bug1355037.patch
Review of attachment 8859134 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for the updated patch!
Attachment #8859134 -
Flags: review?(franziskuskiefer) → review+
|
|
Reporter | |
Comment 6•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.32
You need to log in
before you can comment on or make changes to this bug.
Description
•