Closed
Bug 1355053
Opened 7 years ago
Closed 7 years ago
0.52 - 0.52% compiler_metrics num_static_constructors (linux32, linux64-stylo) regression on push 40479d157fc874df89dd7b7f959f761319aece49 (Wed Mar 15 2017)
Categories
(Core :: Panning and Zooming, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: igoldan, Assigned: kats)
References
Details
(Keywords: regression)
We have detected a build metrics regression from push 40479d157fc874df89dd7b7f959f761319aece49. As author of one of the patches included in that push, we need your help to address this regression. Regressions: 1% compiler_metrics num_static_constructors linux64-stylo debug 191 -> 192 1% compiler_metrics num_static_constructors linux32 debug 191 -> 192 You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=5465 On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format. To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics
Reporter | ||
Updated•7 years ago
|
Component: Untriaged → Panning and Zooming
Product: Firefox → Core
Comment 1•7 years ago
|
||
as a note, we recently shifted our threshold to be last least 3 num_static_constructors to generate an alert, please use this as good information, but maybe not a requirement to do anything.
Assignee | ||
Comment 2•7 years ago
|
||
Is there a way for me to reproduce this locally or on try? (i.e. some way for me to generate the number of constructors). I suspect it's counting [1] as a static constructor but I'd want to modify the line to make sure. [1] https://hg.mozilla.org/mozilla-central/rev/8dcb0cd0ee36#l4.15
Flags: needinfo?(jmaher)
Comment 3•7 years ago
|
||
redirecting to :froydnj, he is the oracle of static constructors :)
Flags: needinfo?(jmaher) → needinfo?(nfroyd)
Comment 4•7 years ago
|
||
Ah, your patch added a new .cpp, so what likely happened is that the particular files in two unified build files got shifted around a bit, and one of those files that didn't have a static constructor previously now does. I don't think you have anything to worry about here.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(nfroyd)
Resolution: --- → WORKSFORME
Assignee | ||
Comment 5•7 years ago
|
||
Ah, thanks!
You need to log in
before you can comment on or make changes to this bug.
Description
•