Closed Bug 1355073 Opened 7 years ago Closed 5 years ago

Accidentally starting a drag on the identity block reloads the page and discards pending permission prompts

Categories

(Firefox :: Address Bar, enhancement, P5)

Product:
Firefox
Component:
Address Bar
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: florian, Assigned: phoenixgyaan, Mentored)

References

Details

Attachments

(1 file)

Bug 1355073 - Accidentally starting a drag on the identity block reloads the page and discards pending permission prompts.
47 bytes, text/x-phabricator-request
Details | Review 
Noticed this while trying to reproduce bug 1345667.

Things we could do:
- ignore a drop when the dropped URL is the same as the current one
- ignore URLs dropped on the identity part of the urlbar.
Marking this as P5, I think it's a good idea but we won't pursue it. If anyone wants to pick it up I'm happy to offer advice. I personally think we should do the former and ignore same URLs.
Mentor: jhofmann
Priority: -- → P5
Assignee: nobody → prathikshaprasadsuman
Assignee: prathikshaprasadsuman → nobody

The drop in the url bar is received here: https://searchfox.org/mozilla-central/rev/486b64e4bff86b7988af8c8b80845404ad197533/browser/base/content/urlbarBindings.xml#1051

We should add some code there that does one of the options mentioned in comment 0.

I would like to take this up please :)

You could assign yourself now :)

Assignee: nobody → phoenixgyaan
Status: NEW → ASSIGNED

Changed the function to now check if the dropped and current URL are not same.

Flags: needinfo?(jhofmann)

Hi Johann, how do I test this change locally..???

Hey, you can just drag the (i) icon in the url bar a few inches and then drop it again, with your new patch it shouldn't reload the page.

Flags: needinfo?(jhofmann)
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/768adc665e9b
Accidentally starting a drag on the identity block reloads the page and discards pending permission prompts. r=johannh

https://hg.mozilla.org/mozilla-central/rev/768adc665e9b

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Component: Site Identity and Permission Panels → Address Bar
Depends on: 1543041
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: