Closed Bug 1355088 Opened 3 years ago Closed 3 years ago

add BUG_COMPONENT to browser/* files

Categories

(Firefox :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed
firefox57 --- fixed

People

(Reporter: armenzg, Assigned: jmaher)

References

Details

Attachments

(3 files)

Attached file browser.json
In bug 1352495 I'm creating a mach subcommand that puts all test files into bug components. I discover that 705 test files don't have a bug component associated to them.

Please look at the attachment for all test files missing this information.
Blocks: 1328351
Comment on attachment 8856513 [details]
browser.json

Hi Mossop, would you mind looking at this attachment and letting me know under which bug component should each of these tests fall under?
Or direct me to someone that could look at this?

We can use this etherpad to make add the information (same information as the attachment):
https://public.etherpad-mozilla.org/p/browser_tests_bug_components
Attachment #8856513 - Attachment mime type: application/json → application/txt
Flags: needinfo?(dtownsend)
I've update the etherpad for everything except the browser/base/content/test/general. That directory is a bit of a mess right now and we know it needs to be split up. It strikes me that it would be a lot easier to split it up first and then assign bug components to the directories. Either way it seems like more work than one person should be tasked with. What is the priority for getting these tests classified?
Flags: needinfo?(dtownsend) → needinfo?(armenzg)
solving most of this, I am still missing:
browser/app/*
browser/base/components/tests/general/ <- the big mess that we should split up
browser/branding/*
browser/components/*
browser/config/*
browser/docs/*
browser/extensions/*
browser/fonts/*
browser/installer/*
browser/locales/*


I will do a second patch to address these other items, and consider breaking up general or just tackling that in a 3rd patch or extra bug.

:mossop, if this should be reviewed by someone else, please redirect.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Flags: needinfo?(armenzg)
Attachment #8859158 - Flags: review?(dtownsend)
Thanks jmaher, mossop!
Comment on attachment 8859158 [details] [diff] [review]
annotate most of browser/* moz.build files

Review of attachment 8859158 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/build/moz.build
@@ +4,5 @@
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> +with Files("**"):
> +    BUG_COMPONENT = ("Firefox", "General")

Firefox::Build Config
Attachment #8859158 - Flags: review?(dtownsend) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d1a1617e805
add BUG_COMPONENT to browser/* files. r=mossop
https://hg.mozilla.org/mozilla-central/rev/6d1a1617e805
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
a few more things to do per comment 3.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8898463 [details] [diff] [review]
annotate the rest of the browser/* files (and fix up some new ones)

Review of attachment 8898463 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/moz.build
@@ +23,5 @@
> +    BUG_COMPONENT = ("Core", "Build Config")
> +with Files("Makefile.in"):
> +    BUG_COMPONENT = ("Core", "Build Config")
> +
> +with Files("profile/**"):

Can you do this just for profile/extensions/{972..., I don't want to accidentally lump any additional files in. Looks like pagethemes.rdf is unused whatever it was and can be deleted.

::: browser/base/content/moz.build
@@ +25,5 @@
>  with Files("pageinfo/**"):
>      BUG_COMPONENT = ("Firefox", "Page Info Window")
>  
> +with Files("test/about/**"):
> +    BUG_COMPONENT = ("Firefox", "Toolbars and Customization")

Firefox::General

@@ +37,5 @@
>  with Files("test/chrome/**"):
>      BUG_COMPONENT = ("Firefox", "General")
>  
> +with Files("test/contextMenu/**"):
> +    BUG_COMPONENT = ("Firefox", "Theme")

Firefox::Menus

@@ +91,5 @@
>  with Files("test/tabs/**"):
>      BUG_COMPONENT = ("Firefox", "Tabbed Browser")
>  
> +with Files("test/touch/**"):
> +    BUG_COMPONENT = ("Firefox", "Theme")

Firefox::General

::: browser/extensions/flyweb/moz.build
@@ +4,5 @@
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> +with Files("**"):
> +    BUG_COMPONENT = ("Firefox", "General")

Core::Networking

::: browser/locales/moz.build
@@ +8,5 @@
> +
> +with Files("**"):
> +    BUG_COMPONENT = ("Toolkit", "Build Config")
> +
> +with Files("all-locales/**"):

No need for /**

@@ +9,5 @@
> +with Files("**"):
> +    BUG_COMPONENT = ("Toolkit", "Build Config")
> +
> +with Files("all-locales/**"):
> +    BUG_COMPONENT = ("Clre", "Localization")

Core::Localization

@@ +12,5 @@
> +with Files("all-locales/**"):
> +    BUG_COMPONENT = ("Clre", "Localization")
> +
> +with Files("en-US/**"):
> +    BUG_COMPONENT = ("Clre", "Localization")

In an ideal world we'd actually assign the locale files to their respective features but Core::Localization is fine for now.

@@ +20,5 @@
> +
> +with Files("searchplugins/**"):
> +    BUG_COMPONENT = ("Firefox", "Search")
> +
> +with Files("shipped-locales/**"):

No need for /**

@@ +21,5 @@
> +with Files("searchplugins/**"):
> +    BUG_COMPONENT = ("Firefox", "Search")
> +
> +with Files("shipped-locales/**"):
> +    BUG_COMPONENT = ("Clre", "Localization")

Core::Localization
Attachment #8898463 - Flags: review?(dtownsend) → review+
thanks, I have made all of these adjustments!
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3455c101b7a
add BUG_COMPONENT to browser/* files. r=mossop
https://hg.mozilla.org/mozilla-central/rev/f3455c101b7a
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/36c4cb7e10d2bb1e182f4a9376c7155a27e12623
chore(build): Backport and fix bug 1355088 to use correct bug component

https://github.com/mozilla/activity-stream/commit/5b80df23babef7b39c470ba3a1b23969cf4c21de
Merge pull request #3245 from Mardak/gh3243-bugs

chore(build): Backport and fix bug 1355088 to use correct bug component
Blocks: 1394533
You need to log in before you can comment on or make changes to this bug.