Closed Bug 1355089 Opened 8 years ago Closed 8 years ago

add BUG_COMPONENT to widget/* files

Categories

(Core :: Widget, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: armenzg, Assigned: jmaher)

References

Details

Attachments

(2 files)

In bug 1352495 I'm creating a mach subcommand that puts all test files into bug components. I discover that 46 test files under widget/ don't have a bug component associated to them. Please look at the attachment for all test files missing this information.
Attached file widget.json
Comment on attachment 8856515 [details] widget.json vlad, would you mind looking at this patch and letting me know under which bug component should each test fall under? Would Core::Widget be good for all of them?
Attachment #8856515 - Attachment mime type: application/json → application/txt
Flags: needinfo?(vladimir)
Blocks: 1328351
No longer blocks: 1351067
there are a lot of files in widget/*, I have attempted to annotate them in a reasonable way- please feel free to r- and suggest other changes or reviewers!
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Flags: needinfo?(vladimir)
Attachment #8857636 - Flags: review?(mstange)
Attachment #8857636 - Flags: review?(jmathies)
Comment on attachment 8857636 [details] [diff] [review] add BUG_COMPONENT to widget/* The test annotations seem surprisingly precise, and possibly hard to maintain. Not sure if they're worth it. The general directory-wide annotations all look good.
Attachment #8857636 - Flags: review?(mstange) → review+
Comment on attachment 8857636 [details] [diff] [review] add BUG_COMPONENT to widget/* Review of attachment 8857636 [details] [diff] [review]: ----------------------------------------------------------------- ::: widget/headless/moz.build @@ +4,5 @@ > # License, v. 2.0. If a copy of the MPL was not distributed with this > # file, You can obtain one at http://mozilla.org/MPL/2.0/. > > +with Files("**"): > + BUG_COMPONENT = ("Firefox", "General") ("Core", "Widget") seem more appropriate ::: widget/tests/moz.build @@ +112,5 @@ > +with Files("*system_status_bar*"): > + BUG_COMPONENT = ("Core", "Widget: Cocoa") > + > +with Files("*taskbar_progress*"): > + BUG_COMPONENT = ("Core", "Widget: Cocoa") ("Core", "Widget: Win32") ::: widget/x11/moz.build @@ +4,5 @@ > # License, v. 2.0. If a copy of the MPL was not distributed with this > # file, You can obtain one at http://mozilla.org/MPL/2.0/. > > +with Files("**"): > + BUG_COMPONENT = ("Core", "Widget") ("Core", "Widget: Gtk") gtk widget consumes this
Attachment #8857636 - Flags: review?(jmathies) → review+
> ::: widget/tests/moz.build > @@ +112,5 @@ > > +with Files("*system_status_bar*"): > > + BUG_COMPONENT = ("Core", "Widget: Cocoa") > > + > > +with Files("*taskbar_progress*"): > > + BUG_COMPONENT = ("Core", "Widget: Cocoa") > > ("Core", "Widget: Win32") Only the taskbar_progress entry here, not system_status_bar.
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ed3c6579e4a8 add BUG_COMPONENT to widget/* files. r=mstange,jimm
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: