add BUG_COMPONENT to widget/* files

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: armenzg, Assigned: jmaher)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
In bug 1352495 I'm creating a mach subcommand that puts all test files into bug components. I discover that 46 test files under widget/ don't have a bug component associated to them.

Please look at the attachment for all test files missing this information.
(Reporter)

Comment 1

2 years ago
Created attachment 8856515 [details]
widget.json
(Reporter)

Comment 2

2 years ago
Comment on attachment 8856515 [details]
widget.json

vlad, would you mind looking at this patch and letting me know under which bug component should each test fall under?

Would Core::Widget be good for all of them?
Attachment #8856515 - Attachment mime type: application/json → application/txt
Flags: needinfo?(vladimir)
(Reporter)

Updated

2 years ago
Blocks: 1328351
No longer blocks: 1351067
(Assignee)

Comment 3

2 years ago
Created attachment 8857636 [details] [diff] [review]
add BUG_COMPONENT to widget/*

there are a lot of files in widget/*, I have attempted to annotate them in a reasonable way- please feel free to r- and suggest other changes or reviewers!
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Flags: needinfo?(vladimir)
Attachment #8857636 - Flags: review?(mstange)
Attachment #8857636 - Flags: review?(jmathies)
Comment on attachment 8857636 [details] [diff] [review]
add BUG_COMPONENT to widget/*

The test annotations seem surprisingly precise, and possibly hard to maintain. Not sure if they're worth it.

The general directory-wide annotations all look good.
Attachment #8857636 - Flags: review?(mstange) → review+
Comment on attachment 8857636 [details] [diff] [review]
add BUG_COMPONENT to widget/*

Review of attachment 8857636 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/headless/moz.build
@@ +4,5 @@
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> +with Files("**"):
> +    BUG_COMPONENT = ("Firefox", "General")

("Core", "Widget")

seem more appropriate

::: widget/tests/moz.build
@@ +112,5 @@
> +with Files("*system_status_bar*"):
> +    BUG_COMPONENT = ("Core", "Widget: Cocoa")
> +
> +with Files("*taskbar_progress*"):
> +    BUG_COMPONENT = ("Core", "Widget: Cocoa")

("Core", "Widget: Win32")

::: widget/x11/moz.build
@@ +4,5 @@
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> +with Files("**"):
> +    BUG_COMPONENT = ("Core", "Widget")

("Core", "Widget: Gtk")

gtk widget consumes this
Attachment #8857636 - Flags: review?(jmathies) → review+
> ::: widget/tests/moz.build
> @@ +112,5 @@
> > +with Files("*system_status_bar*"):
> > +    BUG_COMPONENT = ("Core", "Widget: Cocoa")
> > +
> > +with Files("*taskbar_progress*"):
> > +    BUG_COMPONENT = ("Core", "Widget: Cocoa")
> 
> ("Core", "Widget: Win32")

Only the taskbar_progress entry here, not system_status_bar.

Comment 7

2 years ago
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed3c6579e4a8
add BUG_COMPONENT to widget/* files. r=mstange,jimm
https://hg.mozilla.org/mozilla-central/rev/ed3c6579e4a8
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Depends on: 1368597
Depends on: 1401052
You need to log in before you can comment on or make changes to this bug.