1355089 - add BUG_COMPONENT to widget/* files

Status: RESOLVED FIXED

(Core :: Widget, enhancement)

Description

[Armen [:armenzg]]

In bug 1352495 I'm creating a mach subcommand that puts all test files into bug components. I discover that 46 test files under widget/ don't have a bug component associated to them.

Please look at the attachment for all test files missing this information.

Comment 1

[Armen [:armenzg]]

Attachment: widget.json

Comment 2

[Armen [:armenzg]]

Comment on attachment 8856515 [details]
widget.json

vlad, would you mind looking at this patch and letting me know under which bug component should each test fall under?

Would Core::Widget be good for all of them?

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add BUG_COMPONENT to widget/*

there are a lot of files in widget/*, I have attempted to annotate them in a reasonable way- please feel free to r- and suggest other changes or reviewers!

Comment 4

[Markus Stange [:mstange]]

Comment on attachment 8857636 [details] [diff] [review]
add BUG_COMPONENT to widget/*

The test annotations seem surprisingly precise, and possibly hard to maintain. Not sure if they're worth it.

The general directory-wide annotations all look good.

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 8857636 [details] [diff] [review]
add BUG_COMPONENT to widget/*

Review of attachment 8857636 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/headless/moz.build
@@ +4,5 @@
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> +with Files("**"):
> +    BUG_COMPONENT = ("Firefox", "General")

("Core", "Widget")

seem more appropriate

::: widget/tests/moz.build
@@ +112,5 @@
> +with Files("*system_status_bar*"):
> +    BUG_COMPONENT = ("Core", "Widget: Cocoa")
> +
> +with Files("*taskbar_progress*"):
> +    BUG_COMPONENT = ("Core", "Widget: Cocoa")

("Core", "Widget: Win32")

::: widget/x11/moz.build
@@ +4,5 @@
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> +with Files("**"):
> +    BUG_COMPONENT = ("Core", "Widget")

("Core", "Widget: Gtk")

gtk widget consumes this

Comment 6

[Jim Mathies [:jimm]]

> ::: widget/tests/moz.build
> @@ +112,5 @@
> > +with Files("*system_status_bar*"):
> > +    BUG_COMPONENT = ("Core", "Widget: Cocoa")
> > +
> > +with Files("*taskbar_progress*"):
> > +    BUG_COMPONENT = ("Core", "Widget: Cocoa")
> 
> ("Core", "Widget: Win32")

Only the taskbar_progress entry here, not system_status_bar.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed3c6579e4a8
add BUG_COMPONENT to widget/* files. r=mstange,jimm

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ed3c6579e4a8