1355095 - Network configuration issue on Ubuntu 16.04 Xen VM

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Description

[Dragos Crisan [:dragrom]]

when the network-manager is disabled in puppet, the /etc/network/interfaces files only has a config for 'eth0'.  It looks like the xen vm has ens4 as the interface device name.  This makes me wonder if we should really be disabling the network manager at all. We might need to dig up bugs about it and find out the reason we are disabling it.  Otherwise we will need to fix /etc/network/interfaces with puppet.

Comment 1

[Dragos Crisan [:dragrom]]

We can add in modules/network/manifests/init.pp a case for ubuntu 16.04 and $::virtual='xenhvm' to create the file /etc/network/interfaces from a template, like for CentOs. Hope not brake again CentOS in AWS.

Comment 2

[Dragos Crisan [:dragrom]]

Attachment: puppetagain_network.patch

Comment 3

[Dragos Crisan [:dragrom]]

Attachment: puppetagain_network.patch

Comment 4

[Jake Watkins [:dividehex]]

Comment on attachment 8856989 [details] [diff] [review]
puppetagain_network.patch

Review of attachment 8856989 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/network/manifests/init.pp
@@ +38,5 @@
> +                    if ($::virtual == "xenhvm") {
> +                        file {
> +                            "/etc/network/interfaces":
> +                                content => template("network/ubuntu_interfaces.erb");
> +                        }

This block would fit well in the block below, where $::config::manage_ifcfg is being checked.  Something similar is being done for centos.

Comment 5

[Kendall Libby [:fubar] (he/him)]

Is that ($::virtual == "xenhvm") likely to fall afoul of the issue in bug 1353943#c5 ?

Comment 6

[Jake Watkins [:dividehex]]

(In reply to Kendall Libby [:fubar] from comment #5)
> Is that ($::virtual == "xenhvm") likely to fall afoul of the issue in bug
> 1353943#c5 ?

Only if we haven't figured out why $::virtual == "xenhvm" is true on aws when we start generating 16.04 amis there.

Comment 7

[Amy Rich [:arr] [:arich]]

Since taskcluster AWS infrastructure doesn't use puppet, will this ever be a problem?

Comment 8

[:dhouse]

Applied changes and pushed to default:
remote:   https://hg.mozilla.org/build/puppet/rev/f0618128c00c3293600598ae75f3f986ba2cc459

Comment 9

[:dhouse]

Travis passed
pushed to production:
remote:   https://hg.mozilla.org/build/puppet/rev/eb4123c63159fb24e15fca759ebb1c54250d4469

Comment 10

[:dhouse]

No problems have been reported to the mailing list. So this looks successful to me.

Comment 11

[:dhouse]

I mean "successful" in that it did not break the puppet client runs for aws. I did not test this on one of the new ubuntu 16 boxes.