Closed Bug 1355162 Opened 7 years ago Closed 5 years ago

Add two-finger pan gesture detection for synaptics touchpads that generate touch events

Categories

(Core :: Panning and Zooming, enhancement, P3)

52 Branch
All
Windows
enhancement

Tracking

()

RESOLVED DUPLICATE of bug 1511901
mozilla70

People

(Reporter: kats, Unassigned)

References

Details

(Whiteboard: [gfx-noted])

In bug 1345355 we discovered that some synaptics touchpads/drivers generate WM_TOUCH events when doing a two-finger pan gesture. The two touch points seem to have the same coordinates (i.e. a zero-span pinch). Because we are getting WM_TOUCH events, we go into the APZ pinch-pan code which is not really ideal for this behaviour. Instead, we should try and detect this scenario in the windows widget code (conditional on the hardware input device) and generate PanGestureInput events from the widget instead. APZ can then use the PanGestureInput events to do scrolling.
Note that at least one piece of hardware that has this problem has the following identifiers, as returned by GetRawInputDeviceInfoA(..RIDI_DEVICEINFO..) using the handle from the hSource field of the touch info:

info.dwType = TYPE_HID
info.hid.dwVendorId = 0
info.hid.dwProductId = 0
info.hid.dwVersionNumber = 1
info.hid.usUsagePage = 13
info.hid.usUsage = 4

and GetRawInputDeviceInfoA(..RIDI_DEVICENAME..) returns:
"\\?\VIRTUAL_DIGITIZER" (a 22-byte string including null terminator)
Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information
Priority: P2 → P3

This was fixed in bug 1511901.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
No longer blocks: 1511901

Note, the fix has been uplifted to 70.

Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.