Closed Bug 1355187 Opened 3 years ago Closed 3 years ago

More fixing up of types between Rust and C++

Categories

(Core :: Graphics: WebRender, enhancement, P3)

Other Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(4 files)

For the binding generator to be as seamless as possible we want the types on Rust and C++ sides of the FFI boundary to be as close as possible. I have a set of patches that help with this.
Comment on attachment 8856664 [details]
Bug 1355187 - Update Rust FFI function signatures to use types with Wr prefix.

https://reviewboard.mozilla.org/r/128590/#review131066
Attachment #8856664 - Flags: review?(rhunt) → review+
Comment on attachment 8856665 [details]
Bug 1355187 - Add type aliases for instantiations of WrSideOffsets.

https://reviewboard.mozilla.org/r/128592/#review131068
Attachment #8856665 - Flags: review?(rhunt) → review+
Comment on attachment 8856666 [details]
Bug 1355187 - Rename some struct fields so that the Rust/C++ names are the same.

https://reviewboard.mozilla.org/r/128594/#review131070
Attachment #8856666 - Flags: review?(rhunt) → review+
Comment on attachment 8856667 [details]
Bug 1355187 - Update some of the ExternalImage data types to be more similar in Rust and C++.

https://reviewboard.mozilla.org/r/128596/#review131072
Attachment #8856667 - Flags: review?(rhunt) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/db087d30b56b
Update Rust FFI function signatures to use types with Wr prefix. r=rhunt
https://hg.mozilla.org/projects/graphics/rev/f71d33022a5e
Add type aliases for instantiations of WrSideOffsets. r=rhunt
https://hg.mozilla.org/projects/graphics/rev/223769fd8894
Rename some struct fields so that the Rust/C++ names are the same. r=rhunt
https://hg.mozilla.org/projects/graphics/rev/f8c97e12c904
Update some of the ExternalImage data types to be more similar in Rust and C++. r=rhunt
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.