Closed Bug 1355190 Opened 7 years ago Closed 7 years ago

Add "bg" and "kab" in Fennec maemo-locale for multi-locale builds

Categories

(Firefox for Android Graveyard :: General, enhancement)

Product:
Firefox for Android Graveyard
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(relnote-firefox 54+, firefox54 fixed, firefox55 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
relnote-firefox --- 54+
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: delphine, Assigned: delphine)

References

Details

Attachments

(1 file)

Bug1355190.patch
552 bytes, patch
flod
: review+
gchang
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Bulgarian (bg) and Kabyle (kab) teams have been consistently testing on single-locale builds for a while now, so we are going to add them to multi-locale builds in order for them to move to Beta and then release on the 54 cycle.

Because of upcoming Dawn changes, we'll have to land this on m-c and m-a at this point.
Release Note Request (optional, but appreciated)
[Why is this notable]: New locales
[Suggested wording]: "Locales added: Bulgarian (bg) and Kabyle (kab)"
[Links (documentation, blog post, etc)]:
relnote-firefox: --- → ?
Attached patch Bug1355190.patch — — Splinter Review 

        Attachment #8856673 -
        Flags: review?(francesco.lodolo)

    
    

    
  
Comment on attachment 8856673 [details] [diff] [review]
Bug1355190.patch

Review of attachment 8856673 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

You will need to set the checkin-neeeded keyword to get it landed on mozilla-central, and ask mozilla-aurora approval on the patch as you used to do in the past.

If you feel brave, you could also use mozreview for this kind of patches.

        Attachment #8856673 -
        Flags: review?(francesco.lodolo) → review+

    
    

    
  
(In reply to Francesco Lodolo [:flod] from comment #3)
> Comment on attachment 8856673 [details] [diff] [review]
> 
> If you feel brave, you could also use mozreview for this kind of patches.
Thanks!
Not quite brave enough yet :D (soon though!)

Please land on mozilla-central, and also requesting mozilla-aurora approval (because Dawn).
Keywords: checkin-needed

    
    

    
  
Comment on attachment 8856673 [details] [diff] [review]
Bug1355190.patch

Approval Request Comment
We also will need to get this into mozilla-aurora, as we previously were doing

        Attachment #8856673 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8e5f13e4dbc
Add "bg" and "kab" in Fennec maemo-locale for multi-locale builds. r=flod
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/f8e5f13e4dbc
Status: NEW → RESOLVED
Closed: 7 years ago

          status-firefox55:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

    
    

    
  
Comment on attachment 8856673 [details] [diff] [review]
Bug1355190.patch

Add "bg" and "kab" locales in Fennec. Aurora54+.

        Attachment #8856673 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
    

    
  
Added to Fx54 (Beta) release notes.

          relnote-firefox:
          ? → 54+
Product: Firefox for Android → Firefox for Android Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: