Enable devicemanager debug logging from mach test commands

RESOLVED FIXED in Firefox 55

Status

()

P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gbrown, Assigned: gbrown)

Tracking

Trunk
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
When debugging problems in Android tests initiated from mach, the devicemanager logging can be very useful, but there's no easy way to enable it. Let's hook the mach --log-xxx-level options to devicemanager logging.
(Assignee)

Comment 1

2 years ago
Created attachment 8856716 [details] [diff] [review]
enable devicemanager debug logging when debug mach logging requested

For example,

gbrown@mozpad:~/src$ ./mach reftest --log-tbpl-level=debug layout/reftests/reftest-sanity/reftest.list
mozdevice DEBUG | _runCmd - command: adb version
mozdevice DEBUG | Android Debug Bridge version 1.0.36
mozdevice DEBUG | Revision 0e9850346394-android
mozdevice INFO  | Detected adb 1.0.36
mozdevice DEBUG | _checkCmd - command: adb shell echo
mozdevice DEBUG | 
mozdevice DEBUG | _runCmd - command: adb shell getprop ro.build.version.sdk
mozdevice DEBUG | 18
mozdevice INFO  | Detected Android sdk 18
mozdevice DEBUG | _runCmd - command: adb shell id
mozdevice DEBUG | uid=0(root) gid=0(root) context=u:r:shell:s0
...

I'm hoping this might be helpful in cases such as bug 1354055.
Attachment #8856716 - Flags: review?(jmaher)
Comment on attachment 8856716 [details] [diff] [review]
enable devicemanager debug logging when debug mach logging requested

Review of attachment 8856716 [details] [diff] [review]:
-----------------------------------------------------------------

nice!
Attachment #8856716 - Flags: review?(jmaher) → review+

Comment 3

2 years ago
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6697d89d054
When debug logging requested for android mach test commands, enable devicemanager logging; r=jmaher
(Assignee)

Updated

2 years ago
Priority: -- → P2

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d6697d89d054
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.