1355229 - Please deploy autopush 1.28.0 to STAGE

Status: VERIFIED FIXED

(Cloud Services Graveyard :: Operations: Autopush, task)

Description

[Richard Pappalardo [:rpapa][:rpappalardo]]

------------------
RELEASE NOTES
------------------
https://github.com/mozilla-services/autopush/releases

COMPARISONS
https://github.com/mozilla-services/autopush/compare/1.25.1...1.26.0
https://github.com/mozilla-services/autopush/compare/1.26.0...1.27.0
https://github.com/mozilla-services/autopush/compare/1.27.0...1.28.0

TAGS
https://github.com/mozilla-services/autopush/releases/tag/1.28.0
https://github.com/mozilla-services/autopush/commit/66824517ae332b2176cc01ca50b16b3cd1e1cfc7

CHANGELOG
<a name="1.28.0"></a>
## 1.28.0 (2017-04-07)


#### Refactor

*   cleanup some deferred arg bookkeeping ([55e91c59](https://github.com/mozilla-services/autopush/commit/55e91c59d449c57b1a3d19d803656b8d4323818d))
*   various cleanup ([013db1ca](https://github.com/mozilla-services/autopush/commit/013db1ca1c2d904d78ecca9adb243eb5462d69e2))

#### Features

*   Use cryptography based JWT parser for increased speed ([fe9b7766](https://github.com/mozilla-services/autopush/commit/fe9b7766e4af50452a2cb69fd982bf5c89f74523))

#### Bug Fixes

*   APNS may close a socket prematurely, resulting in an AttributeError ([ed86e267](https://github.com/mozilla-services/autopush/commit/ed86e26706fe0d07bc8849c8dae3e44a72ae0675))
*   Hyphenate `content-available`; don't send `alert` for APNs. ([103e0945](https://github.com/mozilla-services/autopush/commit/103e094508d06700e2d90d05f8a2b442438bbd97))
*   Limit exception trapping to known types when processing crypto-key ([3576d207](https://github.com/mozilla-services/autopush/commit/3576d2075b590861950b984160243de35bf982d5))
*   Fixes for missing UAID and header values ([defb331b](https://github.com/mozilla-services/autopush/commit/defb331b3f8df001a18ee2c58d8363d0929304d0))
*   Use log.error() to better track exceptions in APNS ([8aa510d7](https://github.com/mozilla-services/autopush/commit/8aa510d7c30d4d2748cf3d2d9330e8d3ffb85a78))

Comment 1

[Richard Pappalardo [:rpapa][:rpappalardo]]

----------------------------
URL CHECKS (STAGE)
----------------------------

curl -s 'https://updates-autopush.stage.mozaws.net/health' | python -mjson.tool
{
    "clients": 0,
    "stage.autopush.routerv2": {
        "status": "OK"
    },
    "stage.autopush.storage": {
        "status": "OK"
    },
    "status": "OK",
    "version": "1.28.0"
}


curl -s 'https://updates-autopush.stage.mozaws.net/status' | python -mjson.tool
{
    "status": "OK",
    "version": "1.28.0"
}

Comment 2

[Richard Pappalardo [:rpapa][:rpappalardo]]

--------------------------------
SENTRY TEST
--------------------------------

MY IP: 96.35.52.201


updates-autopush.stage.mozaws.net
{
    "code": 418,
    "errno": 999,
    "error": "Test Failure",
    "message": "FAILURE:Success",
    "more_info": "http://autopush.readthedocs.io/en/latest/http.html#error-codes"
}

	
{'ami_id': 'ami-6ad9507c', 'authorization': [Filtered], 'message_ttl': '', 'python_version': '2.7.12 (aff251e54385, Nov 09 2016, 18:02:49)
[PyPy 5.6.0 with GCC 4.8.2]', 'remote_ip': '96.35.52.201, 172.31.22.8', 'request_id': 'f2c0a2b4-4278-439d-a638-ad679df3463d', 'uri': '/v1/err/crit', 'user_agent': 'curl/7.51.0'}

Comment 3

[Richard Pappalardo [:rpapa][:rpappalardo]]

--------------------------------
E2E TEST: TOPICS
--------------------------------

Additional E2E-test which includes testing of notification bundling for stored messages
https://github.com/jrconlin/topics - follow README

Desktop (Nightly).  -- OK!
Android -- Not Yet Implemented (per :jrconlin)

Comment 4

[Richard Pappalardo [:rpapa][:rpappalardo]]

----------------------------
E2E-TESTS
----------------------------

setting STAGE config to:
dom.push.serverURL = autopush.stage.mozaws.net

DESKTOP E2E PUSH TEST

setup:
start browser with new profile
open: about:config
set: dom.push.loglevel=debug (instead of 'off')
open: Tools > WebDeveloper > BrowserConsole
open: https://mozilla-services.github.io/autopush-e2e-test/
choose: "service-worker.js"
click: "register Service Worker"
click: "subscribe to push"
observe push registration in console
click: "Always Receive Notifications" (in pop-up window)

1. registration test

steps:
click: "XHR to webpush app-server"
observe: successful registration in console

2. message delivery test

setup:
set: Repeat = 2
set: Delay (seconds) = 15

steps:
click: "XHR to webpush app-server"
observe: 2 pop notifications 15 seconds apart
 
3. payload test

setup:
set: Title = PAYLOAD TEST
set: Body = BODY TEXT HERE
set: TTL = 360
set: Repeat = 4
set: Delay (seconds): 20

steps:
click: "XHR to webpush app-server"
observe:
should see delayed pop notifications with Title, Body specified

4. storage test

purpose: verify that a request is stored on autopush for delayed delivery

setup:
(same as 3 above)

steps:
click: "XHR to webpush app-server
wait for pop notification, then immediately close browser
wait 25 seconds
re-open browser
observe:
should see 3 more delayed messages delivered on browser restart

Comment 5

[Richard Pappalardo [:rpapa][:rpappalardo]]

----------------------------
E2E-TESTS: VAPID (+Android)
----------------------------

Additional E2E-test which includes VAPID, encryption:
https://jrconlin.github.io/Webpush_QA/

Desktop (Nightly)  -- OK
Android (Nightly) -- OK

NOTE:

This page can also be used to test Android, however, 
on STAGE / PROD gcm path + senderID must be appended (see below).
oremj> the sender ids are 965234145045 and 829133274407 (for both STAGE & PROD)

 
STAGE:
dom.push.serverURL = https://updates-autopush.stage.mozaws.net/v1/gcm/829133274407

PROD:
dom.push.serverURL = https://updates.push.services.mozilla.com/v1/gcm/829133274407


unlike paths for desktop (uses sockets):

STAGE:
dom.push.serverURL = wss://autopush.stage.mozaws.net/

PROD:
dom.push.serverURL = wss://push.services.mozilla.com/

Comment 6

[Richard Pappalardo [:rpapa][:rpappalardo]]

The ap-loadtester scenarios listed below are failing on STAGE:

aplt.scenarios:notification_forever
aplt.scenarios:notification_forever_stored
aplt.scenarios:notification_forever_unsubscribed

with the following error:
exceptions.TypeError: 'NoneType' object is not subscriptable

Comment 7

[Philip Jenvey [:pjenvey]]

I haven't been able to reproduce this today, running this w/ the latest (8b2437b80a9b) bbangert/ap-loadtester docker, e.g.:

./apenv/bin/aplt_testplan wss://autopush.stage.mozaws.net/ aplt.scenarios:notification_forever_stored,1000,1,0

:rpapa linked this traceback this morning:

https://pastebin.mozilla.org/9018615

I'm wondering if something was misconfigured w/ that run, the endpoint URLs in there look to be pointing to prod:

u'pushEndpoint': u'https://updates.push.services.mozilla.com/wpush/v1/g...

Comment 8

[Philip Jenvey [:pjenvey]]

Additionally that traceback's line number even seemed off:

  File "/Users/rpappalardo/git/ap-loadtester/aplt/scenarios.py", line 237, in notification_forever_unsubscribed

->

https://github.com/mozilla-services/ap-loadtester/blob/master/aplt/scenarios.py#L237

Comment 9

[Richard Pappalardo [:rpapa][:rpappalardo]]

thanks, :pjenvey.

 (In reply to Philip Jenvey [:pjenvey] from comment #8)
> Additionally that traceback's line number even seemed off:
> 
>   File "/Users/rpappalardo/git/ap-loadtester/aplt/scenarios.py", line 237,
> in notification_forever_unsubscribed
> 
> ->
> 
> https://github.com/mozilla-services/ap-loadtester/blob/master/aplt/scenarios.
> py#L237

was able to re-install my test env on linux box and all scenarios passing now.

Verifying STAGE.