Closed
Bug 1355266
Opened 4 years ago
Closed 4 years ago
test_TelemetrySendOldPings is needlessy importing osfile.jsm twice
Categories
(Toolkit :: Telemetry, enhancement, P4)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: marco, Assigned: pauline.lallinec, Mentored)
Details
(Keywords: good-first-bug, Whiteboard: [measurement:client][lang=js])
Attachments
(1 file)
|
1.33 KB,
patch
|
Dexter
:
review+
|
Details | Diff | Splinter Review |
https://hg.mozilla.org/mozilla-central/file/45692c884fdd5136a64fb2f8a61a0c8183b69331/toolkit/components/telemetry/tests/unit/test_TelemetrySendOldPings.js#l12 and https://hg.mozilla.org/mozilla-central/file/45692c884fdd5136a64fb2f8a61a0c8183b69331/toolkit/components/telemetry/tests/unit/test_TelemetrySendOldPings.js#l19. Also https://hg.mozilla.org/mozilla-central/file/45692c884fdd5136a64fb2f8a61a0c8183b69331/toolkit/components/telemetry/tests/unit/test_TelemetrySendOldPings.js#l19 can be `const` instead of `var`.
|
||
Updated•4 years ago
|
Mentor: alessio.placitelli
Points: --- → 1
Priority: -- → P4
Whiteboard: [measurement:client][lang=js]
|
|
||
Comment 2•4 years ago
|
||
(In reply to Pauline from comment #1) > Hi, could I be assigned to this bug? There you go :)
Assignee: nobody → pauline.lallinec
Here it is :-)
Attachment #8859728 -
Flags: review?(alessio.placitelli)
|
|
||
Comment 4•4 years ago
|
||
Comment on attachment 8859728 [details] [diff] [review] removed duplicate import of osfile.jsm Review of attachment 8859728 [details] [diff] [review]: ----------------------------------------------------------------- This looks good, thanks! Did you check that the tests run correctly on your machine by using the following command? > ./mach test toolkit/components/telemetry
Attachment #8859728 -
Flags: review?(alessio.placitelli) → review+
|
|
||
Updated•4 years ago
|
Attachment #8859728 -
Attachment filename: . → 1355266.patch
|
|
||
Comment 5•4 years ago
|
||
Requesting checkin-needed, I've manually tested this locally.
Keywords: checkin-needed
> This looks good, thanks! Did you check that the tests run correctly on your
> machine by using the following command?
I did, and it was :)
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f143c464b7f4 removed duplicate import of osfile.jsm. r=Dexter
Keywords: checkin-needed
|
||
Comment 8•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f143c464b7f4
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•