[ANGLE] (Follow up Bug 1347866)Remove the dependency of SH_UNROLL_FOR_LOOP_WITH_SAMPLER_ARRAY_INDEX

RESOLVED FIXED in Firefox 55

Status

()

Core
Canvas: WebGL
P3
normal
RESOLVED FIXED
8 months ago
2 months ago

People

(Reporter: Lenzak, Assigned: Lenzak)

Tracking

(Depends on: 1 bug)

Trunk
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [gfx-noted])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

ANGLE has dropped SH_UNROLL_FOR_LOOP_WITH_SAMPLER_ARRAY_INDEX in this changeset.
https://github.com/google/angle/commit/1b896c62934be40cf8a37dc28fabc15590c89a5d

However, we need this flag to avoid webgl conformance failures under Linux, so we have to revert this changeset in Bug1347866.

We should remove this dependency for better integration with newer version of ANGLE.

I have tested ANGLE without this flag on gecko, besides test fails on Linux, we also got minor performance regression on Windows and Mac when running EpicZenGarden.

I think we need to figure out how chromium not depend on this flag to run everything correctly.
See Also: → bug 1347866
Blocks: 1347866
See Also: bug 1347866
Chrome has no problem running sampler-array-using-loop-index in webgl conformance test without SH_UNROLL_FOR_LOOP_WITH_SAMPLER_ARRAY_INDEX set under Linux.

I suspect there are some validation code in Gecko prevent us to process the shader code correctly.
Whiteboard: [gfx-noted]
Priority: -- → P3
OK, it seems that the failure only happen on try server, I'll add a fail-if os=='linux' on the mochitest-manifest and remove the flag.
Assignee: nobody → cleu
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 9

8 months ago
mozreview-review
Comment on attachment 8858201 [details]
Bug 1355321 - Part1: Revert "Bug 1347866 - Part2: Revert "translator: remove code related to for-loop unrolling"";

https://reviewboard.mozilla.org/r/130150/#review132884
Attachment #8858201 - Flags: review?(jgilbert) → review+

Comment 10

8 months ago
mozreview-review
Comment on attachment 8858202 [details]
Bug 1355321 - Part2: Remove SH_UNROLL_FOR_LOOP_WITH_SAMPLER_ARRAY_INDEX;

https://reviewboard.mozilla.org/r/130152/#review132886
Attachment #8858202 - Flags: review?(jgilbert) → review+

Comment 11

8 months ago
mozreview-review
Comment on attachment 8858203 [details]
Bug 1355321 - Part3: Add fail-if to prevent orange light on tryserver;

https://reviewboard.mozilla.org/r/130154/#review132888
Attachment #8858203 - Flags: review?(jgilbert) → review+
Keywords: checkin-needed

Comment 12

8 months ago
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6a54d6dacf9b
Part1: Revert "Bug 1347866 - Part2: Revert "translator: remove code related to for-loop unrolling""; r=jgilbert
https://hg.mozilla.org/integration/autoland/rev/31967bdfb50d
Part2: Remove SH_UNROLL_FOR_LOOP_WITH_SAMPLER_ARRAY_INDEX; r=jgilbert
https://hg.mozilla.org/integration/autoland/rev/a6563c2d3699
Part3: Add fail-if to prevent orange light on tryserver; r=jgilbert
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/31967bdfb50d
https://hg.mozilla.org/mozilla-central/rev/a6563c2d3699
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Depends on: 1399501
You need to log in before you can comment on or make changes to this bug.