1355339 - Bug filer should suppress some useless crash signatures (or maybe refuse to file the bugs completely?)

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

There's a (non-comprehensive) list of things at https://github.com/mozilla/treeherder/blob/ac04d5ab8c314d046016b501720d1be564b62568/treeherder/model/error_summary.py#L160 which are not helpful for getting good bug suggestions. 

The bug filer should know about that list and either not include crash signatures matching something in the list, or perhaps outright refusing to file a bug with the blacklisted entries.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:b1355339 > mozilla:master

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

That list might need updating.

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 8856873 [details] [review]
[treeherder] KWierso:b1355339 > mozilla:master

Have left some comments on the PR :-)

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8856873 [details] [review]
[treeherder] KWierso:b1355339 > mozilla:master

Removed the copied blacklist and just warn when the selected failure has no search_terms defined or if the summary does not contain a substring of the selected failure's search_terms.

Comment 5

[Ed Morley [:emorley]]

Comment on attachment 8856873 [details] [review]
[treeherder] KWierso:b1355339 > mozilla:master

Have left some comments

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8856873 [details] [review]
[treeherder] KWierso:b1355339 > mozilla:master

How about this?

Comment 7

[Ed Morley [:emorley]]

Comment on attachment 8856873 [details] [review]
[treeherder] KWierso:b1355339 > mozilla:master

r+ with the comment addressed :-)

Many thanks!

Comment 8

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/443ee67652440df89d27b9bb38f26b60dd927be3
Bug 1355339 - Make the bug filer warn when it doesn't match any of the failure's search terms (#2336) r=emorley

If the selected failure has no search_terms defined, the bug being filed will never appear as a suggestion for classification. Warn in this case.

If the bug-to-be-filed's summary does not contain any of the selected failure's search_terms, it will never appear as a suggestion for the classification. Warn in this case. The search terms are displayed in this case so the user can see exactly what needs to be added to make the bug discoverable.