Closed Bug 1355342 Opened 3 years ago Closed 3 years ago

[tcmigration] track Fennec mozilla-release 53.0 possible migration missing pieces

Categories

(Release Engineering :: Release Automation: Other, enhancement, P1)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mtabara, Assigned: mtabara)

References

Details

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1355341 +++

We might be off-guard in some aspects with respect to automation. Lots of stuff that's currently working for Firefox/Fennec in beta might break for mozilla-release. 

This is a tracking bug to remember what we've done, if any.
Summary: [tcmigration] deal with TC migration changes for Fennec mozilla-release 53.0 → [tcmigration] track Fennec mozilla-release 53.0 possible migration missing pieces
Starting the investigation now ... 
First things first, we'll need new templates here (as in, Fennec release templates).

https://github.com/mozilla/releasetasks/tree/master/releasetasks/release_configs
1. Releasetasks templates in the r? PR.

2. Created corresponding Fennec release hook[1] for nightly graph.

3. Afaik, each hook needs an associated role, so I crated/granted this[2] role and granted it the existing mozilla-release role/set of scopes[3]

4. I double checked the BBB based builders and couldn't find anything suspicious. The nightly graph is important anyway, any of the BBB based jobs can be manually done too if we have too so I'm less concerned about these.

Note to self: we need to rethink how we're adding these roles or wipe them off completely? Might not even need them as tasks are submitted via bm85/bm83 relpro client which is empowered to do almost anything. See Firefox for more details. We need to backout this[4] change to make it work again in 54.0b1 Fennec release.

[1]: https://tools.taskcluster.net/hooks/#project-releng/candidates-fennec-release
[2]: https://tools.taskcluster.net/auth/roles/#hook-id:project-releng%252fcandidates-fennec-release
[3]: assume:project:releng:release:mozilla-release
Assignee: nobody → mtabara
Status: NEW → ASSIGNED
Attachment #8856958 - Flags: review?(aki)
Attachment #8856958 - Flags: review?(aki) → review+
I just gave the beta scopes to the release role, so we should be good without backing out.
(In reply to Aki Sasaki [:aki] from comment #3)
> I just gave the beta scopes to the release role, so we should be good
> without backing out.

That sounds good too, thanks!
Priority: -- → P1
Comment on attachment 8857727 [details]
Bug 1355342 - [Fennec Relpro] Prevent releases from being handled by buildbot

https://reviewboard.mozilla.org/r/129670/#review132294

lgtm+
Attachment #8857727 - Flags: review?(nthomas) → review+
https://hg.mozilla.org/build/tools/rev/9c090317e75f
Bug 1355342 - [Fennec Relpro] Prevent releases from being handled by buildbot r=nthomas
Forgot initially to add this role/scope[0] to the promotion client[1] itself.

[0]: assume:hook-id:project-releng/candidates-fennec-release
[1]: https://tools.taskcluster.net/auth/clients/#project%252freleng%252freleasepromotion%252fproduction
Fennec 53.0.1 had buildbot automation trigger [!]
I had to cancel Fennec buildbot builds through self-serve.
(In reply to Aki Sasaki [:aki] from comment #9)
> Fennec 53.0.1 had buildbot automation trigger [!]
> I had to cancel Fennec buildbot builds through self-serve.

tl;dr This is entirely my fault. Due to bug 1356092 I never updated the tools on bm81 since I haven't seen those tests running.
Did the tools update + restarted supervisorctl.


[cltbld@buildbot-master81.... tools]$ hg log -l 1
changeset:   7360:172a81d0d5ab
branch:      old-release-runner
tag:         tip
parent:      6951:b6eca0165947
user:        Johan Lorenzo <jlorenzo@mozilla.com>
date:        Mon Feb 20 14:44:50 2017 +0100
summary:     Bug 1340548 - [Fennec Relpro] Prevent betas from being handled by buildbot (aka old release runner) r=mtabara

[cltbld@buildbot-master81.bb.releng.scl3.mozilla.com tools]$ hg pull
...
adding changesets
adding manifests
adding file changes
added 108 changesets with 405 changes to 157 files
(run 'hg update' to get a working copy)

[cltbld@buildbot-master81.bb.releng.scl3.mozilla.com tools]$ hg up old-release-runner
1 files updated, 0 files merged, 0 files removed, 0 files unresolved

[cltbld@buildbot-master81.bb.releng.scl3.mozilla.com tools]$ hg heads
...
changeset:   7450:9c090317e75f
branch:      old-release-runner
parent:      7360:172a81d0d5ab
user:        Mihai Tabara <mtabara@mozilla.com>
date:        Thu Apr 13 09:33:54 2017 +0800
summary:     Bug 1355342 - [Fennec Relpro] Prevent releases from being handled by buildbot r=nthomas
I think we are done for now. We've successfully shipped 53.0.
If anything else comes up, will reopen and add further along.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.