Three profiler tweaks

RESOLVED FIXED in Firefox 55

Status

()

Core
Gecko Profiler
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: njn, Assigned: njn)

Tracking

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

8 months ago
I have three profiler tweaks.
(Assignee)

Comment 1

8 months ago
Created attachment 8856881 [details] [diff] [review]
(part 1) - Rename profiled_thread_ and profiled_thread() in PlatformData
Attachment #8856881 - Flags: review?(jseward)
(Assignee)

Updated

8 months ago
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
(Assignee)

Comment 2

8 months ago
Created attachment 8856884 [details] [diff] [review]
(part 2) - Avoid a GetThreadHandle() call

Using ProfiledThread() instead avoids a cast.
Attachment #8856884 - Flags: review?(jseward)
(Assignee)

Comment 3

8 months ago
Created attachment 8856886 [details] [diff] [review]
(part 3) - Construct nativeStack with the right count
Attachment #8856886 - Flags: review?(jseward)
Attachment #8856881 - Flags: review?(jseward) → review+
Attachment #8856884 - Flags: review?(jseward) → review+
Comment on attachment 8856886 [details] [diff] [review]
(part 3) - Construct nativeStack with the right count

Review of attachment 8856886 [details] [diff] [review]:
-----------------------------------------------------------------

Ok as far as it goes.  I looked at this and thought "Why doesn't NativeStack
have a constructor?  Why the (to me) strange struct assignment to initialise?"
Attachment #8856886 - Flags: review?(jseward) → review+
(Assignee)

Comment 5

8 months ago
> Ok as far as it goes.  I looked at this and thought "Why doesn't NativeStack
> have a constructor?  Why the (to me) strange struct assignment to
> initialise?"

For this case -- a vanilla struct with no private fields or anything like that -- I think that style of initialization is reasonable. So I'll leave it as is.
(Assignee)

Comment 6

8 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/afaa171e1ff0c3ab9ff4405e938d6b49d950881c
Bug 1355357 (part 1) - Rename profiled_thread_ and profiled_thread() in PlatformData. r=jseward.

https://hg.mozilla.org/integration/mozilla-inbound/rev/acee2bb51c1f9db3544397108c57d94c3ffcfccb
Bug 1355357 (part 2) - Avoid a GetThreadHandle() call. r=jseward.

https://hg.mozilla.org/integration/mozilla-inbound/rev/059fc26d261d2342c79265a58a7281cdc626084c
Bug 1355357 (part 3) - Construct nativeStack with the right count. r=jseward.

Comment 7

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/afaa171e1ff0
https://hg.mozilla.org/mozilla-central/rev/acee2bb51c1f
https://hg.mozilla.org/mozilla-central/rev/059fc26d261d
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.