Closed Bug 1355357 Opened 3 years ago Closed 3 years ago

Three profiler tweaks

Categories

(Core :: Gecko Profiler, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(3 files)

I have three profiler tweaks.
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Using ProfiledThread() instead avoids a cast.
Attachment #8856884 - Flags: review?(jseward)
Attachment #8856881 - Flags: review?(jseward) → review+
Attachment #8856884 - Flags: review?(jseward) → review+
Comment on attachment 8856886 [details] [diff] [review]
(part 3) - Construct nativeStack with the right count

Review of attachment 8856886 [details] [diff] [review]:
-----------------------------------------------------------------

Ok as far as it goes.  I looked at this and thought "Why doesn't NativeStack
have a constructor?  Why the (to me) strange struct assignment to initialise?"
Attachment #8856886 - Flags: review?(jseward) → review+
> Ok as far as it goes.  I looked at this and thought "Why doesn't NativeStack
> have a constructor?  Why the (to me) strange struct assignment to
> initialise?"

For this case -- a vanilla struct with no private fields or anything like that -- I think that style of initialization is reasonable. So I'll leave it as is.
https://hg.mozilla.org/integration/mozilla-inbound/rev/afaa171e1ff0c3ab9ff4405e938d6b49d950881c
Bug 1355357 (part 1) - Rename profiled_thread_ and profiled_thread() in PlatformData. r=jseward.

https://hg.mozilla.org/integration/mozilla-inbound/rev/acee2bb51c1f9db3544397108c57d94c3ffcfccb
Bug 1355357 (part 2) - Avoid a GetThreadHandle() call. r=jseward.

https://hg.mozilla.org/integration/mozilla-inbound/rev/059fc26d261d2342c79265a58a7281cdc626084c
Bug 1355357 (part 3) - Construct nativeStack with the right count. r=jseward.
You need to log in before you can comment on or make changes to this bug.