Closed
Bug 1355399
Opened 8 years ago
Closed 8 years ago
Switch order for async-from-sync iterator property getting
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
3.02 KB,
patch
|
arai
:
review+
|
Details | Diff | Splinter Review |
Per https://github.com/tc39/proposal-async-iteration/commit/395b2e3b2f5acb62f9fae11c5e189423d4af50e6
|
Assignee | |
Comment 1•8 years ago
|
||
Simply switches the property retrieval for "value" and "done" in js::AsyncFromSyncIteratorMethod(). Test262 tests are already updated, so we should probably sync our local copy in the next few days to pick up the changes.
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8856901 -
Flags: review?(arai.unmht)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8856901 [details] [diff] [review] bug1355399.patch Review of attachment 8856901 [details] [diff] [review]: ----------------------------------------------------------------- Nice :D
Attachment #8856901 -
Flags: review?(arai.unmht) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a386db07b835ff6c41de6e7fe3eda34e817080f
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c6a5fde1bfc1 Switch property retrieval in Async-from-Sync Iterator prototype methods. r=arai
Keywords: checkin-needed
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c6a5fde1bfc1
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•