NSS tool for encryption

RESOLVED FIXED in 3.31

Status

NSS
Tools
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: fkiefer, Assigned: fkiefer)

Tracking

trunk
3.31

Firefox Tracking Flags

(Not tracked)

Details

A simple tool to encrypt/decrypt files.
https://hg.mozilla.org/projects/nss/rev/fa15eb3ce158e708381c48a5bd3dba462f5d4c2d
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED

Comment 2

7 months ago
Bug:

../../nss-tool/enc/enctool.cc: In member function ‘bool EncTool::DoCipher(std::__cxx11::string, std::__cxx11::string, bool, EncTool::key_func_t)’:
../../nss-tool/enc/enctool.cc:241:12: error: enum constant in boolean context [-Werror=int-in-bool-context]
     return SECFailure;
            ^~~~~~~~~~
../../nss-tool/enc/enctool.cc:247:12: error: enum constant in boolean context [-Werror=int-in-bool-context]
     return SECFailure;
            ^~~~~~~~~~
../../nss-tool/enc/enctool.cc:255:12: error: enum constant in boolean context [-Werror=int-in-bool-context]
     return SECFailure;
            ^~~~~~~~~~

These errors will be incorrectly reported as successes.  That's probably bad.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Oh, that slipped through. Not sure why my compiler didn't complain about this. What did you use to get these errors?
https://hg.mozilla.org/projects/nss/rev/0658e7288f208215ff5bf426c8e42cff5099b59e
Status: REOPENED → RESOLVED
Last Resolved: 8 months ago7 months ago
Resolution: --- → FIXED
Fixed some issues on Windows https://hg.mozilla.org/projects/nss/rev/e2d089908d9997d8effd62ba0c8cbf384a20acc2
You need to log in before you can comment on or make changes to this bug.