1355439 - Startup Crash in CrashReporter::TerminateHandler via nsAbOSXDirectory::Init [Mac]

Status: VERIFIED FIXED

(Thunderbird :: Address Book, defect)

Description

[Wayne Mery (:wsmwk)]

#1 crash for Mac users on THunderbird 52.0. And all crashes with this signature are version 52.0 and "newer". https://crash-stats.mozilla.com/signature/?product=Thunderbird&signature=CrashReporter%3A%3ATerminateHandler&date=%3E%3D2017-01-11T11%3A10%3A20.000Z&date=%3C2017-04-11T11%3A10%3A20.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_sort=-date&page=1#reports

Both 10.11 and 10.12. None of the crashes have comments. Perhaps it correlates to previously reported Mac bugs of this liniage, i.e. bug 1286613 etc - I won't have time to investigate any time soon.

bp-0b91e028-4a62-4b3f-8861-3df572170411
 0 	XUL	CrashReporter::TerminateHandler()	toolkit/crashreporter/nsExceptionHandler.cpp:1521
1 	libc++abi.dylib	std::__terminate(void (*)())	
2 	libc++abi.dylib	__cxa_rethrow	
3 	libobjc.A.dylib	objc_exception_rethrow	
4 	AddressBook	+[ABAddressBook sharedAddressBook]	
5 	XUL	nsAbOSXDirectory::Init(char const*)	/builds/slave/tb-rel-c-esr52-m64_bld-0000000/build/mailnews/addrbook/src/nsAbOSXDirectory.mm:466
6 	XUL	nsAbManager::GetDirectory(nsACString_internal const&, nsIAbDirectory**)	/builds/slave/tb-rel-c-esr52-m64_bld-0000000/build/mailnews/addrbook/src/nsAbManager.cpp:295
7 	XUL	nsAbOSXDirFactory::GetDirectories(nsAString_internal const&, nsACString_internal const&, nsACString_internal const&, nsISimpleEnumerator**)	/builds/slave/tb-rel-c-esr52-m64_bld-0000000/build/mailnews/addrbook/src/nsAbOSXDirFactory.cpp:32
8 	XUL	nsAbBSDirectory::CreateDirectoriesFromFactory(nsACString_internal const&, DIR_Server*, bool)	/builds/slave/tb-rel-c-esr52-m64_bld-0000000/build/mailnews/addrbook/src/nsAbBSDirectory.cpp:57
9 	XUL	nsAbBSDirectory::EnsureInitialized()	/builds/slave/tb-rel-c-esr52-m64_bld-0000000/build/mailnews/addrbook/src/nsAbBSDirectory.cpp:151
10 	XUL	nsAbBSDirectory::GetChildNodes(nsISimpleEnumerator**)	/builds/slave/tb-rel-c-esr52-m64_bld-0000000/build/mailnews/addrbook/src/nsAbBSDirectory.cpp:94
11 	XUL	nsAbManager::GetDirectories(nsISimpleEnumerator**)	/builds/slave/tb-rel-c-esr52-m64_bld-0000000/build/mailnews/addrbook/src/nsAbManager.cpp:202
12 	XUL	NS_InvokeByIndex	xpcom/reflect/xptcall/md/unix/xptcinvoke_x86_64_unix.cpp:180
13 	XUL	XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode)	js/xpconnect/src/XPCWrappedNative.cpp:2058
14 	XUL	XPC_WN_GetterSetter(JSContext*, unsigned int, JS::Value*)	js/xpconnect/src/xpcprivate.h:1824
15 	XUL	js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct)	js/src/jscntxtinlines.h:239
16 	XUL	CallGetter	js/src/vm/Interpreter.cpp:523

Comment 1

[Makoto Kato [:m_kato]]

Why doesn't addrbook use NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT?  Since this code is objective-c, it can throw exception, so when using objective-c, Gecko must use NS_OBJC_BEGIN_TRY_ABORT_BLOCK.

Comment 2

[Wayne Mery (:wsmwk)]

#3 Mac crash for 52.1.0

Comment 3

[Wayne Mery (:wsmwk)]

Easily fixed?

(In reply to Makoto Kato [:m_kato] from comment #1)
> Why doesn't addrbook use NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT?  Since this
> code is objective-c, it can throw exception, so when using objective-c,
> Gecko must use NS_OBJC_BEGIN_TRY_ABORT_BLOCK.

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Use NS_OBJC_BEGIN_TRY_ABORT_BLOCK

Comment 5

[Makoto Kato [:m_kato]]

Attachment: Use NS_OBJC_BEGIN_TRY_ABORT_BLOCK

I don't know how to reproduce this.

But objective-c code might throw exception, so we should catch that exception.

Comment 6

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=7cc887a5b472e1b97d7eb14cd5dfe4fdb1494a70

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 8880737 [details] [diff] [review]
Use NS_OBJC_BEGIN_TRY_ABORT_BLOCK

Looks good to me. I'm not a Mac expert at all, but the code changes won't do any damage and hopefully avoid crashes.

Let me land that myself after an M-C merge.

Comment 8

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/baa69f1f608ef4dbb94bf5cf1bb3d02c30f5d4dd

Comment 9

[Jorg K (CEST = GMT+2)]

Comment on attachment 8880737 [details] [diff] [review]
Use NS_OBJC_BEGIN_TRY_ABORT_BLOCK

No harm in uplifting this.

Comment 10

[Wayne Mery (:wsmwk)]

(In reply to Jorg K (GMT+2) from comment #9)
> Comment on attachment 8880737 [details] [diff] [review]
> Use NS_OBJC_BEGIN_TRY_ABORT_BLOCK
> 
> No harm in uplifting this.

Beta history [1] shows far not crashes for 56.0b2, and #26 crash for 55.0b2.(impossible to tell by nightly stats) Hopefully this does kill it in 52.x

[1] https://crash-stats.mozilla.com/signature/?release_channel=beta&signature=CrashReporter%3A%3ATerminateHandler&date=%3E%3D2017-05-14T06%3A13%3A09.000Z&date=%3C2017-08-14T06%3A13%3A09.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_sort=-date&page=1#reports

Comment 11

[Jorg K (CEST = GMT+2)]

TB 52.3 ESR:
https://hg.mozilla.org/releases/comm-esr52/rev/866343b5d902

Comment 12

[Wayne Mery (:wsmwk)]

crash via nsAbOSXDirectory::Init is gone in 52.3.0 and 56.0beta