|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
In https://github.com/devtools-html/reps/pull/122, we modify Reps to functional components, and `createFactories` isn't needed anymore. We now plan to remove it from the reps bundle. Since there are some modules in m-c that relies on `createFactories` (dom panel, json viewer, net monitor), we should move it to devtools/client/shared and change all the call sites to the moved version.
Attachment #8857350 - Flags: review?(jdescottes)
Comment on attachment 8857350 [details] Bug 1355454 - Move "createFactories" function from Reps to a shared util. https://reviewboard.mozilla.org/r/129336/#review131958 LGTM! Thanks
Attachment #8857350 - Flags: review?(jdescottes) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/dfa8f3b410b8 Move "createFactories" function from Reps to a shared util. r=jdescottes
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.