Move `createFactories` function from Reps to devtools/client/shared

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Developer Tools: Shared Components
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: nchevobbe, Assigned: nchevobbe)

Tracking

unspecified
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
In https://github.com/devtools-html/reps/pull/122, we modify Reps to functional components, and `createFactories` isn't needed anymore. 
We now plan to remove it from the reps bundle.
Since there are some modules in m-c that relies on `createFactories` (dom panel, json viewer, net monitor), we should move it to devtools/client/shared and change all the call sites to the moved version.
(Assignee)

Updated

a year ago
Assignee: nobody → nchevobbe
(Assignee)

Updated

a year ago
Priority: -- → P1
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8857350 - Flags: review?(jdescottes)

Comment 3

a year ago
mozreview-review
Comment on attachment 8857350 [details]
Bug 1355454 - Move "createFactories" function from Reps to a shared util.

https://reviewboard.mozilla.org/r/129336/#review131958

LGTM! Thanks
Attachment #8857350 - Flags: review?(jdescottes) → review+

Comment 4

a year ago
Pushed by chevobbe.nicolas@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/dfa8f3b410b8
Move "createFactories" function from Reps to a shared util. r=jdescottes

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/dfa8f3b410b8
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.