1355454 - Move `createFactories` function from Reps to devtools/client/shared

Status: RESOLVED FIXED

(DevTools :: Shared Components, enhancement, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

In https://github.com/devtools-html/reps/pull/122, we modify Reps to functional components, and `createFactories` isn't needed anymore. 
We now plan to remove it from the reps bundle.
Since there are some modules in m-c that relies on `createFactories` (dom panel, json viewer, net monitor), we should move it to devtools/client/shared and change all the call sites to the moved version.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1355454 - Move "createFactories" function from Reps to a shared util.

Review commit: https://reviewboard.mozilla.org/r/129336/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129336/

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

TRY seems fine https://treeherder.mozilla.org/#/jobs?repo=try&revision=42ca2579fb99

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8857350 [details]
Bug 1355454 - Move "createFactories" function from Reps to a shared util.

https://reviewboard.mozilla.org/r/129336/#review131958

LGTM! Thanks

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfa8f3b410b8
Move "createFactories" function from Reps to a shared util. r=jdescottes

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dfa8f3b410b8