Photon toolbar button icon drop

VERIFIED FIXED in Firefox 57

Status

()

Firefox
Theme
P1
normal
VERIFIED FIXED
4 months ago
11 days ago

People

(Reporter: dao, Assigned: nhnt11)

Tracking

(Blocks: 3 bugs)

Trunk
Firefox 57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 verified)

Details

(Whiteboard: [photon-visual][p1][57])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

4 months ago
Bug 1347543 switches us from Toolbar.png to SVGs, so later we should be able to drop in new icons without much manual CSS work.
(Reporter)

Updated

4 months ago
Whiteboard: [photon][57] → [photon-visual][57]
(Reporter)

Updated

4 months ago
Summary: Toolbar button icon drop → Photon toolbar button icon drop

Updated

4 months ago
Flags: qe-verify+
Priority: P1 → P2
QA Contact: ovidiu.boca
(Reporter)

Updated

4 months ago
Whiteboard: [photon-visual][57] → [photon-visual][p1][57]

Updated

4 months ago
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Iteration: --- → 55.4 - May 1
Priority: P2 → P1

Updated

4 months ago
QA Contact: ovidiu.boca → brindusa.tot

Updated

4 months ago
Iteration: 55.4 - May 1 → 55.5 - May 15
(Reporter)

Updated

4 months ago
Depends on: 1362083
(Reporter)

Updated

4 months ago
status-firefox55: affected → ---
Depends on: 1363028
(Reporter)

Updated

3 months ago
No longer depends on: 1363028
(Reporter)

Updated

3 months ago
Assignee: nhnt11 → nobody
Status: ASSIGNED → NEW
Iteration: 55.5 - May 15 → ---
Priority: P1 → P2
(Reporter)

Updated

3 months ago
Blocks: 1364999
(Reporter)

Updated

3 months ago
Blocks: 1365003

Updated

3 months ago
See Also: → bug 1366844
(Reporter)

Updated

3 months ago
Depends on: 1367015
(Reporter)

Updated

2 months ago
Blocks: 1372689
(Reporter)

Updated

2 months ago
Blocks: 1129657

Updated

a month ago
Duplicate of this bug: 1379465
Duplicate of this bug: 1380464
Blocks: 1382588
(Reporter)

Updated

a month ago
No longer blocks: 1372689
(Reporter)

Updated

21 days ago
Blocks: 1366555
(Reporter)

Comment 3

21 days ago
Nihanth, could you please prepare a patch for this? Would be nice to land this straight after 56 moves to beta.
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Flags: needinfo?(nhnt11)
Priority: P2 → P1

Updated

21 days ago
Iteration: --- → 56.4 - Aug 1
Comment hidden (mozreview-request)
(Assignee)

Updated

20 days ago
Flags: needinfo?(nhnt11)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Reporter)

Comment 7

19 days ago
mozreview-review
Comment on attachment 8892119 [details]
Bug 1355455 - Replace shared icons with Photon versions.

https://reviewboard.mozilla.org/r/163108/#review168420
Attachment #8892119 - Flags: review?(dao+bmo) → review+

Updated

19 days ago
Blocks: 1386361

Updated

18 days ago
Iteration: 56.4 - Aug 1 → 57.1 - Aug 15

Comment 8

18 days ago
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 4ddd90d91cdc -d f91c159b3170: rebasing 411079:4ddd90d91cdc "Bug 1355455 - Replace shared icons with Photon versions. r=dao" (tip)
merging browser/themes/shared/customizableui/customizeMode.inc.css
merging browser/themes/shared/icons/device-desktop.svg
merging browser/themes/shared/icons/device-mobile.svg
merging browser/themes/shared/icons/email-link.svg
merging browser/themes/shared/jar.inc.mn
merging browser/themes/shared/tabs.inc.css
warning: conflicts while merging browser/themes/shared/icons/device-desktop.svg! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/themes/shared/icons/device-mobile.svg! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/themes/shared/icons/email-link.svg! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request)

Comment 10

18 days ago
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5c84321d226e
Replace shared icons with Photon versions. r=dao
Backed out for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=120535233&repo=autoland

https://hg.mozilla.org/integration/autoland/rev/c7fda3c9ff866a9c830f8a91068af3e27a64238a
Flags: needinfo?(nhnt11)
Comment hidden (mozreview-request)
(Assignee)

Comment 13

17 days ago
A whitelisted image was renamed; I updated the entry in the test file and re-landed.
Flags: needinfo?(nhnt11)

Comment 14

17 days ago
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c9c1ce4407b9
Replace shared icons with Photon versions. r=dao
https://hg.mozilla.org/mozilla-central/rev/c9c1ce4407b9
Status: ASSIGNED → RESOLVED
Last Resolved: 17 days ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Screenshots:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=d942ef54fdf726840a698d2ddcaf989d2c00edbc&newProject=mozilla-central&newRev=681a2489f6a92a09f87336c4ebfcd55030ffcda1

(We're still working on showing Windows comparisons after the taskcluster switch, you can check out the Windows screenshots here: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=681a2489f6a92a09f87336c4ebfcd55030ffcda1&filter-tier=1&filter-tier=2&filter-tier=3&exclusion_profile=false&filter-searchStr=ss&selectedJob=120695185)
Hi Nihanth,

I have a question about this issue, I see on the screenshots that the "Pocket" should be near the menu icon, but on Nightly 57.0a1(2017-08-07) and on mockup page: http://design.firefox.com/people/shorlander/photon/Mockups/macOS.html the "Pocket" icon is in the address bar. Can you please clarify where this should be? Thanks
Flags: needinfo?(nhnt11)
(Reporter)

Comment 18

11 days ago
(In reply to ovidiu boca[:Ovidiu] from comment #17)
> Hi Nihanth,
> 
> I have a question about this issue, I see on the screenshots that the
> "Pocket" should be near the menu icon, but on Nightly 57.0a1(2017-08-07) and
> on mockup page:
> http://design.firefox.com/people/shorlander/photon/Mockups/macOS.html the
> "Pocket" icon is in the address bar. Can you please clarify where this
> should be? Thanks

It should be in the address bar.
Flags: needinfo?(nhnt11)
Thanks Dão,

I tested this issue on Ubuntu 16.04, Mac OS X 10.12, Windows 10, Windows 7 with the latest Nightly 57.0a1(2017-08-08) I can confirm the fix.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.