1355455 - Photon toolbar button icon drop

Status: VERIFIED FIXED

(Firefox :: Theme, enhancement, P1)

Description

[Dão Gottwald [:dao]]

Bug 1347543 switches us from Toolbar.png to SVGs, so later we should be able to drop in new icons without much manual CSS work.

Comment 3

[Dão Gottwald [:dao]]

Nihanth, could you please prepare a patch for this? Would be nice to land this straight after 56 moves to beta.

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1355455 - Replace shared icons with Photon versions.

Review commit: https://reviewboard.mozilla.org/r/163108/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163108/

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8892119 [details]
Bug 1355455 - Replace shared icons with Photon versions.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/163108/diff/1-2/

Comment 6

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8892119 [details]
Bug 1355455 - Replace shared icons with Photon versions.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/163108/diff/2-3/

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 8892119 [details]
Bug 1355455 - Replace shared icons with Photon versions.

https://reviewboard.mozilla.org/r/163108/#review168420

Comment 8

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 4ddd90d91cdc -d f91c159b3170: rebasing 411079:4ddd90d91cdc "Bug 1355455 - Replace shared icons with Photon versions. r=dao" (tip)
merging browser/themes/shared/customizableui/customizeMode.inc.css
merging browser/themes/shared/icons/device-desktop.svg
merging browser/themes/shared/icons/device-mobile.svg
merging browser/themes/shared/icons/email-link.svg
merging browser/themes/shared/jar.inc.mn
merging browser/themes/shared/tabs.inc.css
warning: conflicts while merging browser/themes/shared/icons/device-desktop.svg! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/themes/shared/icons/device-mobile.svg! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/themes/shared/icons/email-link.svg! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 9

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8892119 [details]
Bug 1355455 - Replace shared icons with Photon versions.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/163108/diff/3-4/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c84321d226e
Replace shared icons with Photon versions. r=dao

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=120535233&repo=autoland

https://hg.mozilla.org/integration/autoland/rev/c7fda3c9ff866a9c830f8a91068af3e27a64238a

Comment 12

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8892119 [details]
Bug 1355455 - Replace shared icons with Photon versions.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/163108/diff/4-5/

Comment 13

[(inactive) Nihanth Subramanya [:nhnt11]]

A whitelisted image was renamed; I updated the entry in the test file and re-landed.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9c1ce4407b9
Replace shared icons with Photon versions. r=dao

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c9c1ce4407b9

Comment 16

[Johann Hofmann [:johannh]]

Screenshots:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=d942ef54fdf726840a698d2ddcaf989d2c00edbc&newProject=mozilla-central&newRev=681a2489f6a92a09f87336c4ebfcd55030ffcda1

(We're still working on showing Windows comparisons after the taskcluster switch, you can check out the Windows screenshots here: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=681a2489f6a92a09f87336c4ebfcd55030ffcda1&filter-tier=1&filter-tier=2&filter-tier=3&exclusion_profile=false&filter-searchStr=ss&selectedJob=120695185)

Comment 17

[ovidiu boca[:Ovidiu]]

Hi Nihanth,

I have a question about this issue, I see on the screenshots that the "Pocket" should be near the menu icon, but on Nightly 57.0a1(2017-08-07) and on mockup page: http://design.firefox.com/people/shorlander/photon/Mockups/macOS.html the "Pocket" icon is in the address bar. Can you please clarify where this should be? Thanks

Comment 18

[Dão Gottwald [:dao]]

(In reply to ovidiu boca[:Ovidiu] from comment #17)
> Hi Nihanth,
> 
> I have a question about this issue, I see on the screenshots that the
> "Pocket" should be near the menu icon, but on Nightly 57.0a1(2017-08-07) and
> on mockup page:
> http://design.firefox.com/people/shorlander/photon/Mockups/macOS.html the
> "Pocket" icon is in the address bar. Can you please clarify where this
> should be? Thanks

It should be in the address bar.

Comment 19

[ovidiu boca[:Ovidiu]]

Thanks Dão,

I tested this issue on Ubuntu 16.04, Mac OS X 10.12, Windows 10, Windows 7 with the latest Nightly 57.0a1(2017-08-08) I can confirm the fix.