1355460 - Speculatively connect to bookmarked sites on mousedown

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, enhancement, P3)

Description

[Florian Quèze [:florian]]

When the user presses the left mouse button on a bookmark item (either from the bookmark menu or from the bookmark toolbar), or on a history item, we have a strong signal that the user is about to load that page, so we should speculatively connect to the server.

Comment 1

[Marco Bonardo [:mak]]

This should be behind a pref, a boolean browser.places.speculativeConnect.enabled would probably be fine, since it mirrors the browser.urlbar. one.
For testing, I assume here we'll add an helper method to PlacesUIUtils, the test can then use the Sinon library to replace the method with a Spy, and just check it's invoked.
We'd also support this only for views that allow a single selection, so menus and toolbars. The trees are often used to manage and move bookmarks around with D&D, and we don't want those actions to begin connections.

This is an example of how the Urlbar implements it: https://searchfox.org/mozilla-central/rev/dc323d0d9a3b722ca8ff0d1b2b752e5bd00dab9b/browser/components/urlbar/UrlbarUtils.jsm#728-730,753-757

Comment 2

[Jane Kotovich (:janey)]

Attachment: Bug 1355460 - Speculatively connect toolbar & menu to bookmarked site on mousedown. r?mak

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9ab66e133a3
Speculatively connect toolbar & menu to bookmarked site on mousedown. r=mak

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f9ab66e133a3

Comment 5

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Hello, would manual QA testing be needed for this issue? If yes, could you please provide the steps needed to properly verify this? Thank you.

Comment 6

[Marco Bonardo [:mak]]

(In reply to Ardelean Oana from comment #5)

Hello, would manual QA testing be needed for this issue? If yes, could you please provide the steps needed to properly verify this? Thank you.

I don't think we need manual QA, we have an automated test, it's a minor perf improvement that doesn't ideally show anything different to the user.