If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

colors of images over saturated in 52.0.2

UNCONFIRMED
Unassigned

Status

()

Core
GFX: Color Management
P5
normal
UNCONFIRMED
5 months ago
3 months ago

People

(Reporter: Jack Tummers, Unassigned)

Tracking

({regressionwindow-wanted})

52 Branch
regressionwindow-wanted
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [gfx-noted])

Attachments

(3 attachments)

(Reporter)

Description

5 months ago
Created attachment 8856962 [details]
firefox_vs_chrome.jpg

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/57.0.2987.98 Chrome/57.0.2987.98 Safari/537.36

Steps to reproduce:

Images with ICC profile previously uploaded to website look suddenly over saturated only in Firefox. This was not so before with older versions. Colors look accurate in Chrome, Internet Explorer, Aftershot Pro en Gimp on Linux Mint 18, 64 bit. Compare them using the images on this page: http://www.jacktummers.com/-/galleries/projects/my-life-in-the-zoo

I tried all possible combinations of color management using an color managemant add on or by changing settings in about:config. I also reset Firefox to default values, but no change. I also did some checks on websites to see if browser is using color management, and the check turns out that Firefox is using color management. Nevertheless the images look over saturated.



Expected results:

Displaying accurate colors.

Comment 1

5 months ago
Did it use to work in previous versions of Firefox?
Component: Untriaged → GFX: Color Management
Flags: needinfo?(jack)
Product: Firefox → Core
(Reporter)

Comment 2

5 months ago
Yes it did. Just very recently, and my quess is with the latest version (?), I noticed the colors were so saturated. I find it difficult to find the cause, but because I use color management on my Linux pc, calibrated the monitor and use the profile system wide and where needed linked to the color profile, and because I used to have color management in Firefox too, I came to the 'conclusion' that it could have to do something with this version of Firefox. I also removed Firefox from my system, deleted all folders and did a clean install, then changed and tested several color settings in Firefox (about:config), and all of these settings give the same result, whereas in other programs and other browsers I get the right colors.
Flags: needinfo?(jack)
You could use mozregression http://mozilla.github.io/mozregression/ to narrow down to find out which patch caused the change.

Comment 4

5 months ago
Yes, a regression range would be useful.
Run the command "mozregression --good=51" then make the test for each build launched by the tool and paste here the final pushlog.
Flags: needinfo?(jack)
Keywords: regressionwindow-wanted
Created attachment 8858244 [details]
firefox vs chrome on Windows 10.PNG

I have tested this issue using the latest Nightly on Windows 10 x64 and Ubuntu 16.04 x64 and I can see no differences between Firefox and Chrome.
Created attachment 8858245 [details]
Screenshot from 2017-04-14 11_04_16.png

Attached screen shot of Firefox vs Chrome on Ubuntu 14.04.

Jack, could you please follow the instructions from comment 4, because this seems specific to your set-up.
(Reporter)

Comment 7

5 months ago
Yes, I will do those tests, hopefully this weekend.
So this means that you don't see those over saturated colors? That would be very good, then at least everyone else is notseeing those ugly colors ;). But because I use this browser everyday I will do those checks and come back here when I find the cause. Thanks for testing! :)

Jack
Flags: needinfo?(jack)
(Reporter)

Comment 8

5 months ago
I'm afraid this is not going to work for me, the testing I mean :(. I installed mozregression and tried it, but when it asks me to test and tell the program if this was a good or bad version, I can't say it is or isn't. Because I have to test and make changes in about:config, but that requires Firefox to restart, and that makes the whole proces stop and the commandline tool is also 'reset'. I have no idea what to do next. At the moment I'm just hoping that this problem will disappear in the next version of Firefox, and until that time, unfortunately, I must be using Chrome.
Why do you need to make changes to about:config to test? That might explain what you are seeing.

You can do that a few different ways with mozregression. You can change prefs by using the --pref command line argumenet with mozregression. You can also control which profile mozregression uses with --profile and --profile-persistence. mozregression --help explains how to use them.
(Reporter)

Comment 10

5 months ago
That is all too complicated for me :), but I did notice something. To reset about:config I closed Firefox and deleted the prefs.js file. I do not have a user.js file. After restarting Firefox I can see the prefs.js file is recreated, but all changes in about:config are still there, nothing is reset. Do I need to delete some other files as well?

Comment 11

5 months ago
There is nothing complicated.

1) Create a test profile, it takes 30 sec: 
https://support.mozilla.org/t5/Install-and-Update/Use-the-Profile-Manager-to-create-and-remove-Firefox-profiles/ta-p/2914
Call it e.g. "test", and configure it like your normal profile for the color management settings to reproduce the issue.

2) Run mozregression with these commands:
mozregression --good=51 (or older) --profile=/path_to_test_profile --profile-persistence=reuse

For each build launched by mozregression, load the image in the Nightly and check if the colors are good or bad.
Then when you get the final pushlog, paste the URL here.

Comment 12

5 months ago
Use this link:
https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles

instead of the previous I gave.
(Reporter)

Comment 13

5 months ago
I think I found the problem! But not the solution...

I used the Color Management add-on to link Firefox to an older .icc profile I still had on my hard drive. After restart I can see the colors as they should be!, and as good as with the new color profile. That means that my new and most recently created monitor profile, using Spider 4 and DisplayCal (on Linux), is accepted and used by my system and all software I use, including Gimp, Geeqie, Aftershot Pro, Darktable, Chrome etc., but not by Firefox.

The only thing I can try is to calibrate my monitor again and hope it will accept this new profile. It is strange though, because I'm using the same method of calibrating my monitor for about two years, and Firefox always used this profile correctly, but only starting with the profile from february 2th 2017 it seems to be wrong.
(In reply to Jack Tummers from comment #13)
> The only thing I can try is to calibrate my monitor again and hope it will
> accept this new profile. It is strange though, because I'm using the same
> method of calibrating my monitor for about two years, and Firefox always
> used this profile correctly, but only starting with the profile from
> february 2th 2017 it seems to be wrong.

Did you bisect the problem to feb 2? Did you get a link to hg.mozilla.org that listed all the changesets for that date?
(Reporter)

Comment 15

5 months ago
So I used Mozregression, trying nightlies even back to january 1th 2016, but the problem with the colors persists, while I am positive that a month or two ago everything was fine because I did not change anything to my workflow of editing and publishing my pictures for a long time. The only thing I can think of now is that somehow the color profile was not created optimally and that Firefox has a problem with this and the rest of my software hasn't. So I will create a new profile this week and see if that helps.
Priority: -- → P5
Whiteboard: [gfx-noted]
(Reporter)

Comment 16

5 months ago
Could someone please check this profile?
https://jackdaw.stackstorage.com/s/YjneoFDDRTo8de3

I did a new calibration, and again the profile is used system wide, except by Firefox.
(Reporter)

Comment 17

3 months ago
I'm back ;), because I can't figure out why I'm still seeing (all) images in Firefox more saturated that in all other browsers and programs. It doesn't even matter what settings I choose in about:config or using the color management add on. I even deleted Firefox from my pc, including the settings folders, re-installed everything, uploaded images with or without icc profile etc., nothing matters. Images are displayed correctly on my Linux pc (Ubuntu Linux Mint) in Chrome, Opera, Aftershot Pro, Geeqie, Gimp, Digikam, Darktable etc. etc, just not in Firefox.

https://jackdaw.stackstorage.com/s/YxViYzONK60Rpoj
(Firefox on the left, much too saturated)

The only thing I could find on the internet is that (my) Firefox doesn't handle ICC 4 profiles, only ICC 2
http://www.color.org/version4html.xalter

As a webdesigner and photographer it's impossible for me now to work with Firefox.
You need to log in before you can comment on or make changes to this bug.