1355463 - Allow Bugzilla->params to be cached by memcached

Status: NEW

(bugzilla.mozilla.org :: General, enhancement, P3)

Description

[Dylan Hardison [:dylan] (he/him)]

1 db call + 1 call to Safe->reval() is quite a few milliseconds. 

- cache in Bugzilla->params
- invalidate cache on Bugzilla::Config::write_file();

Comment 1

[:Atoll]

Some context from bug 1355169: The ->params call is used in the 'should we rate limit this request' code, or will be. That makes this code that's on a hot path for processing all incoming requests, and so making this more efficient will ensure that rate limiting does not perform slowly as a result.

Comment 2

[:Atoll]

Dylan, does ->params show up on your perf reports as a high consumer of wall clock?

Comment 3

[Dylan Hardison [:dylan] (he/him)]

This will use Bugzilla->memcached->set_config(), ->get_config(), and clear_config()

Comment 4

[Dylan Hardison [:dylan] (he/him)]

(In reply to Richard Soderberg [:atoll] from comment #2)
> Dylan, does ->params show up on your perf reports as a high consumer of wall
> clock?

Since I never answered here -- yes, it's pretty expensive for the first call in a request.
We have create a new 'Safe' and eval perl code, which is one of the slowest things we could do. it's slow enough that upstream switched to JSON::XS.