Closed Bug 1355471 Opened 3 years ago Closed 3 years ago

Improve timeout deserialisation error message

Categories

(Testing :: Marionette, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox53 fixed, firefox54 fixed, firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox53 --- fixed
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

Attachments

(1 file)

As can be seen from https://github.com/mozilla/geckodriver/issues/633, the error messages from the Set Timeouts command are not obvious.  It first look as the type of the value, but a more useful error message would explain that it is the key, or field, that is not recognised.

We can rectify this in Marionette by reordering the assertions.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment on attachment 8856975 [details]
Bug 1355471 - Test timeout field before value's typing;

https://reviewboard.mozilla.org/r/128886/#review131426
Attachment #8856975 - Flags: review?(hskupin) → review+
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/64fa27c7e727
Test timeout field before value's typing; r=whimboo
https://hg.mozilla.org/mozilla-central/rev/64fa27c7e727
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Sheriffs: Please uplift to Aurora and Beta as test-only.
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]
https://hg.mozilla.org/releases/mozilla-aurora/rev/999732bc0d64
Whiteboard: [checkin-needed-aurora][checkin-needed-beta] → [checkin-needed-beta]
You need to log in before you can comment on or make changes to this bug.