Closed
Bug 1355471
Opened 7 years ago
Closed 7 years ago
Improve timeout deserialisation error message
Categories
(Remote Protocol :: Marionette, enhancement)
Tracking
(firefox53 fixed, firefox54 fixed, firefox55 fixed)
RESOLVED
FIXED
mozilla55
People
(Reporter: ato, Assigned: ato)
Details
Attachments
(1 file)
As can be seen from https://github.com/mozilla/geckodriver/issues/633, the error messages from the Set Timeouts command are not obvious. It first look as the type of the value, but a more useful error message would explain that it is the key, or field, that is not recognised. We can rectify this in Marionette by reordering the assertions.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8856975 [details] Bug 1355471 - Test timeout field before value's typing; https://reviewboard.mozilla.org/r/128886/#review131426
Attachment #8856975 -
Flags: review?(hskupin) → review+
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/64fa27c7e727 Test timeout field before value's typing; r=whimboo
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/64fa27c7e727
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee | ||
Comment 5•7 years ago
|
||
Sheriffs: Please uplift to Aurora and Beta as test-only.
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]
Comment 6•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/999732bc0d64
status-firefox54:
--- → fixed
Whiteboard: [checkin-needed-aurora][checkin-needed-beta] → [checkin-needed-beta]
Comment 7•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/37076febf926 https://hg.mozilla.org/releases/mozilla-release/rev/37076febf926
status-firefox53:
--- → fixed
Whiteboard: [checkin-needed-beta]
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•